You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "peter-toth (via GitHub)" <gi...@apache.org> on 2023/09/11 08:38:32 UTC
[GitHub] [spark] peter-toth opened a new pull request, #42869: [SPARK-45109][SQL][CONNECT][FOLLOWUP] Fix log function in Connect
peter-toth opened a new pull request, #42869:
URL: https://github.com/apache/spark/pull/42869
### What changes were proposed in this pull request?
This is a follow-up PR to https://github.com/apache/spark/pull/42863, the 1 argument `log` function should also point to `ln`.
### Why are the changes needed?
Bugfix.
### Does this PR introduce _any_ user-facing change?
No, these Spark Connect functions haven't been released.
### How was this patch tested?
Exsiting UTs.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth closed pull request #42869: [SPARK-45109][SQL][CONNECT][FOLLOWUP] Fix log function in Connect
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth closed pull request #42869: [SPARK-45109][SQL][CONNECT][FOLLOWUP] Fix log function in Connect
URL: https://github.com/apache/spark/pull/42869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #42869: [SPARK-45109][SQL][CONNECT][FOLLOWUP] Fix log function in Connect
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #42869:
URL: https://github.com/apache/spark/pull/42869#issuecomment-1713445746
For some reasons, it can't find the build. The build is here: https://github.com/peter-toth/spark/actions/runs/6143939836/job/16668358616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #42869: [SPARK-45109][SQL][CONNECT][FOLLOWUP] Fix log function in Connect
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #42869:
URL: https://github.com/apache/spark/pull/42869#issuecomment-1713430742
cc @zhengruifeng, @xuanyuanking, @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #42869: [SPARK-45109][SQL][CONNECT][FOLLOWUP] Fix log function in Connect
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #42869:
URL: https://github.com/apache/spark/pull/42869#issuecomment-1714277374
3.4 PR: https://github.com/apache/spark/pull/42872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #42869: [SPARK-45109][SQL][CONNECT][FOLLOWUP] Fix log function in Connect
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #42869:
URL: https://github.com/apache/spark/pull/42869#issuecomment-1713453795
> For some reasons, it can't find the build. The build is here: https://github.com/peter-toth/spark/actions/runs/6143939836/job/16668358616
Yeah I notivced that and force pushed a new commit so test are running now.
But I've run into this issue a few times, it happened here too: https://github.com/apache/spark/pull/42863#issuecomment-1712779217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on pull request #42869: [SPARK-45109][SQL][CONNECT][FOLLOWUP] Fix log function in Connect
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on PR #42869:
URL: https://github.com/apache/spark/pull/42869#issuecomment-1714271924
Thanks for the review! Merged to master/3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #42869: [SPARK-45109][SQL][CONNECT][FOLLOWUP] Fix log function in Connect
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on code in PR #42869:
URL: https://github.com/apache/spark/pull/42869#discussion_r1321232095
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -2632,7 +2632,7 @@ object functions {
* @group math_funcs
* @since 3.4.0
*/
- def log(e: Column): Column = Column.fn("log", e)
Review Comment:
If we want to directly backport this fix to 3.4, I think `Column.fn("ln", e)` maybe better, otherwise, we may need separate PR for 3.4 since `def ln` was added in 3.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] peter-toth commented on a diff in pull request #42869: [SPARK-45109][SQL][CONNECT][FOLLOWUP] Fix log function in Connect
Posted by "peter-toth (via GitHub)" <gi...@apache.org>.
peter-toth commented on code in PR #42869:
URL: https://github.com/apache/spark/pull/42869#discussion_r1321825840
##########
connector/connect/client/jvm/src/main/scala/org/apache/spark/sql/functions.scala:
##########
@@ -2632,7 +2632,7 @@ object functions {
* @group math_funcs
* @since 3.4.0
*/
- def log(e: Column): Column = Column.fn("log", e)
Review Comment:
I will open a 3.4 version later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org