You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/04/30 06:43:28 UTC

[GitHub] [incubator-nuttx] Oxore opened a new pull request #918: tmpfs: Fix tmpfs_foreach recursively removing files in directories

Oxore opened a new pull request #918:
URL: https://github.com/apache/incubator-nuttx/pull/918


   Fixes #912
   
   ## Summary
   
   This PR fixes `tmpfs_foreach` unconditionally and recursively removing files in directories of any mounted TMPFS. It is ok when it called from `tmpfs_unbind` op, but it shouldn't delete any files if called from `tmpfs_statfs`.
   
   ## Impact
   
   - TMPFS usage statistics analysis (statfs) operation.
   - TMPFS umount (unbind) operation.
   
   ## Testing
   
   Tested `tmpfs_statfs` case only, which is called when running `df` command or reading `/proc/fs/usage`. It seems like values in `/proc/fs/usage` are increasing now if more files created and all files remains unchanged in any directory of TMPFS.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #918: tmpfs: Fix tmpfs_foreach recursively removing files in directories

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #918:
URL: https://github.com/apache/incubator-nuttx/pull/918#issuecomment-621660295


   > Chekpatch points to lines, that have not been affected by this PR's changes. What should I do in this case?
   
   Yes, the contributor has to fix the style issue in the code base per the dissussion in dev@nuttx.apache.org.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #918: tmpfs: Fix tmpfs_foreach recursively removing files in directories

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #918:
URL: https://github.com/apache/incubator-nuttx/pull/918#issuecomment-621670380


   @Oxore To make this a little easier on you, this patch would likely resolve them.
   [0001-Fix-nxstyle-issues-in-tmpfs.patch.txt](https://github.com/apache/incubator-nuttx/files/4556820/0001-Fix-nxstyle-issues-in-tmpfs.patch.txt)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Oxore commented on pull request #918: tmpfs: Fix tmpfs_foreach recursively removing files in directories

Posted by GitBox <gi...@apache.org>.
Oxore commented on pull request #918:
URL: https://github.com/apache/incubator-nuttx/pull/918#issuecomment-621678709


   @btashton Sorry, didn't noticed your comment in time, and fixed it a little in a different way.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] Oxore commented on pull request #918: tmpfs: Fix tmpfs_foreach recursively removing files in directories

Posted by GitBox <gi...@apache.org>.
Oxore commented on pull request #918:
URL: https://github.com/apache/incubator-nuttx/pull/918#issuecomment-621651581


   Chekpatch points to lines, that have not been affected by this PR's changes. What should I do in this case?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] btashton commented on pull request #918: tmpfs: Fix tmpfs_foreach recursively removing files in directories

Posted by GitBox <gi...@apache.org>.
btashton commented on pull request #918:
URL: https://github.com/apache/incubator-nuttx/pull/918#issuecomment-621679545


   All good. Since it was your first contribution to the project via GitHub just wanted to make sure you had what you needed. Thanks for taking care of it. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org