[jira] [Commented] (BIGTOP-2443) inject unzip method to ZipInputStream, accepting regex for include

["Konstantin Boudnik (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BIGTOP-2443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420532#comment-15420532 ] 

Konstantin Boudnik commented on BIGTOP-2443:
--------------------------------------------

Thanks for picking this up!
The review will follow shortly ;)

> inject unzip method to ZipInputStream, accepting regex for include
> ------------------------------------------------------------------
>
>                 Key: BIGTOP-2443
>                 URL: https://issues.apache.org/jira/browse/BIGTOP-2443
>             Project: Bigtop
>          Issue Type: Improvement
>          Components: tests
>    Affects Versions: 0.1.0
>            Reporter: Konstantin Boudnik
>            Assignee: Kengo Seki
>             Fix For: 1.2.0
>
>         Attachments: BIGTOP-2443.1.patch, BIGTOP-2443.2.patch
>
>
> I must admit, I did a lousy job, when the unzip() method was initially injected into {{ZipInputStream}} inside of the {{JarContent}} class. Includes are matched to the jar entries using {{String.contains()}}, which is a way too explicit. 
> Let's add another one, that will accept regex and, even, a list of regex'es.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)