You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by GitBox <gi...@apache.org> on 2020/07/06 11:12:48 UTC
[GitHub] [metamodel] arjansh opened a new pull request #243: Workaround for fieldnames with dots in elasticsearch
arjansh opened a new pull request #243:
URL: https://github.com/apache/metamodel/pull/243
MetaModel is unable to work with a document indexed by Elasticsearch which contains dots in its field names. Note that this is actually caused by Elasticsearch, because the mapping returned for such a document by Elasticsearch doesn't match the source returned by Elasticsearch when getting the source of a search hit. (see https://github.com/elastic/elasticsearch-hadoop/issues/853 and related issues for more info on this).
Note that the branch for this PR is branch off of the branch for https://github.com/apache/metamodel/pull/242, because it extends the Integration Test which is introduced in that PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [metamodel] jhorcicka commented on a change in pull request #243: Workaround for fieldnames with dots in elasticsearch
Posted by GitBox <gi...@apache.org>.
jhorcicka commented on a change in pull request #243:
URL: https://github.com/apache/metamodel/pull/243#discussion_r450215387
##########
File path: elasticsearch/common/src/main/java/org/apache/metamodel/elasticsearch/common/ElasticSearchUtils.java
##########
@@ -290,6 +290,23 @@ public static Row createRow(final Map<String, Object> sourceMap, final String do
} else {
values[i] = valueToDate;
}
+ } else if (column.getType() == ColumnType.MAP && value == null) {
+ // Because of a bug in Elasticsearch, when field names contain dots, it's possible that the
+ // mapping of the index described a column to be of the type "MAP", while it's based on a number
+ // of fields contains dots in their name. In this case we may have to work around that
Review comment:
"contains dots..." => "containing dots..."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [metamodel] asfgit merged pull request #243: Workaround for fieldnames with dots in elasticsearch
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #243:
URL: https://github.com/apache/metamodel/pull/243
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org