You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/08/31 08:40:34 UTC
[GitHub] [beam] Mark-Zeng opened a new pull request #12735: [BEAM-9543] Add blog post for MATCH_RECOGNIZE
Mark-Zeng opened a new pull request #12735:
URL: https://github.com/apache/beam/pull/12735
- added blog post for MATCH\_RECOGNIZE implementation
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website | Whitespace
--- | --- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12735: [BEAM-9543] Add blog post for MATCH_RECOGNIZE
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12735:
URL: https://github.com/apache/beam/pull/12735#issuecomment-690808007
Is this ready to be merged?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on pull request #12735: [BEAM-9543] Add blog post for MATCH_RECOGNIZE
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #12735:
URL: https://github.com/apache/beam/pull/12735#issuecomment-683999553
I guess what the `Whitespace` check is just formatting issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on a change in pull request #12735: [BEAM-9543] Add blog post for MATCH_RECOGNIZE
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #12735:
URL: https://github.com/apache/beam/pull/12735#discussion_r490542490
##########
File path: website/www/site/content/en/blog/pattern-match-beam-sql.md
##########
@@ -0,0 +1,167 @@
+---
+title: "Pattern Matching with Beam SQL"
+date: 2020-08-27 00:00:01 +0800
+aliases:
+ - /blog/2020/08/27/pattern-match-beam-sql.html
+categories:
+ - blog
+authors:
+ - Mark-Zeng
Review comment:
Ah Yes you are right.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on pull request #12735: [BEAM-9543] Add blog post for MATCH_RECOGNIZE
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #12735:
URL: https://github.com/apache/beam/pull/12735#issuecomment-683998812
+1 on this blog. Overall it looks nice!
After you address the comment. I will check why `Run Whitespace PreCommit` is wrong. It seems have broken somehow.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on a change in pull request #12735: [BEAM-9543] Add blog post for MATCH_RECOGNIZE
Posted by GitBox <gi...@apache.org>.
amaliujia commented on a change in pull request #12735:
URL: https://github.com/apache/beam/pull/12735#discussion_r480358627
##########
File path: website/www/site/content/en/blog/pattern-match-beam-sql.md
##########
@@ -0,0 +1,167 @@
+---
+title: "Pattern Matching with Beam SQL"
+date: 2020-08-27 00:00:01 +0800
+aliases:
+ - /blog/2020/08/27/pattern-match-beam-sql.html
+categories:
+ - blog
+authors:
+ - Mark-Zeng
Review comment:
Better to your real name and email :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia merged pull request #12735: [BEAM-9543] Add blog post for MATCH_RECOGNIZE
Posted by GitBox <gi...@apache.org>.
amaliujia merged pull request #12735:
URL: https://github.com/apache/beam/pull/12735
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Mark-Zeng commented on a change in pull request #12735: [BEAM-9543] Add blog post for MATCH_RECOGNIZE
Posted by GitBox <gi...@apache.org>.
Mark-Zeng commented on a change in pull request #12735:
URL: https://github.com/apache/beam/pull/12735#discussion_r480846030
##########
File path: website/www/site/content/en/blog/pattern-match-beam-sql.md
##########
@@ -0,0 +1,167 @@
+---
+title: "Pattern Matching with Beam SQL"
+date: 2020-08-27 00:00:01 +0800
+aliases:
+ - /blog/2020/08/27/pattern-match-beam-sql.html
+categories:
+ - blog
+authors:
+ - Mark-Zeng
Review comment:
Would using github handle automatically render into my real name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] aaltay commented on pull request #12735: [BEAM-9543] Add blog post for MATCH_RECOGNIZE
Posted by GitBox <gi...@apache.org>.
aaltay commented on pull request #12735:
URL: https://github.com/apache/beam/pull/12735#issuecomment-694467358
@amaliujia - what is the next step on this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Mark-Zeng commented on pull request #12735: [BEAM-9543] Add blog post for MATCH_RECOGNIZE
Posted by GitBox <gi...@apache.org>.
Mark-Zeng commented on pull request #12735:
URL: https://github.com/apache/beam/pull/12735#issuecomment-683648925
R: @amaliujia cc: @aaltay @jhnmora000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] amaliujia commented on pull request #12735: [BEAM-9543] Add blog post for MATCH_RECOGNIZE
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #12735:
URL: https://github.com/apache/beam/pull/12735#issuecomment-683999317
Run Whitespace PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org