You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by "magyari-adam (via GitHub)" <gi...@apache.org> on 2024/12/11 07:57:15 UTC
[PR] FINERACT-1806: fix ProductToGLAccountMapping [fineract]
magyari-adam opened a new pull request, #4215:
URL: https://github.com/apache/fineract/pull/4215
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1806: fix ProductToGLAccountMapping [fineract]
Posted by "janez89 (via GitHub)" <gi...@apache.org>.
janez89 commented on PR #4215:
URL: https://github.com/apache/fineract/pull/4215#issuecomment-2535339487
It looks good to me and just one note. If we touch these low-level SQL read services may would be nice to turn that concatenated strings into Java 15 multiline strings. If that string contains a full SQL command then the IDE is just able to highlight and autocomplete based on existing schema.
https://github.com/apache/fineract/pull/4215/files#diff-2829a1a1111b3ced1fafd92d86574a957a2fa73d42fe5112f135301b71fda1c5R62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1806: fix ProductToGLAccountMapping [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy closed pull request #4215: FINERACT-1806: fix ProductToGLAccountMapping
URL: https://github.com/apache/fineract/pull/4215
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] FINERACT-1806: fix ProductToGLAccountMapping [fineract]
Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy commented on PR #4215:
URL: https://github.com/apache/fineract/pull/4215#issuecomment-2551754409
Completed and merged by https://github.com/apache/fineract/pull/4228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org