You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/09/27 15:16:37 UTC

[GitHub] [lucene] gsmiller opened a new pull request, #11828: TermInSetQuery optimization when all docs in a field match a term

gsmiller opened a new pull request, #11828:
URL: https://github.com/apache/lucene/pull/11828

   ### Description
   
   This changes the optimization present in `TermInSetQuery` to mimic the one in `MultiTermQueryConstantScoreWrapper`, bringing parity to the two approaches. More specifically, it optimizes the case where all docs with a value for the referenced field contain a given term (rather than requiring all docs in the segment to contain the term). The solution for `MultiTermQueryConstantScoreWrapper` was discussed in PR #11738 for reference.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] gsmiller commented on pull request #11828: TermInSetQuery optimization when all docs in a field match a term

Posted by GitBox <gi...@apache.org>.
gsmiller commented on PR #11828:
URL: https://github.com/apache/lucene/pull/11828#issuecomment-1261195636

   > I assume we already have tests that cover this case?
   
   Good question. I'm going to go tweak our tests. We added tests that cover the completely dense case (i.e., all docs in a segment) when adding that optimization, but we should augment the tests for this more specific optimization. Will rev the PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] gsmiller merged pull request #11828: TermInSetQuery optimization when all docs in a field match a term

Posted by GitBox <gi...@apache.org>.
gsmiller merged PR #11828:
URL: https://github.com/apache/lucene/pull/11828


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene] mikemccand commented on pull request #11828: TermInSetQuery optimization when all docs in a field match a term

Posted by GitBox <gi...@apache.org>.
mikemccand commented on PR #11828:
URL: https://github.com/apache/lucene/pull/11828#issuecomment-1262145491

   Awesome use of Lucene's aggregate (corpus) statistics!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org