[GitHub] [arrow-datafusion] jackwener opened a new pull request, #6824: minor: with_inputs() can use original schema.

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener opened a new pull request, #6824:
URL: https://github.com/apache/arrow-datafusion/pull/6824

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Closes #.
   
   # Rationale for this change
   
   following #6820 
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   # Are there any user-facing changes?
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jackwener commented on a diff in pull request #6824: minor: with_inputs() can use original schema.

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener commented on code in PR #6824:
URL: https://github.com/apache/arrow-datafusion/pull/6824#discussion_r1249555539


##########
datafusion/core/src/physical_planner.rs:
##########
@@ -958,10 +958,9 @@ impl DefaultPhysicalPlanner {
                                 })
                                 .collect::<Vec<_>>();
                             let projection =
-                                logical_plan::Projection::try_new_with_schema(

Review Comment:
   here we shouldn't use `join_schema`, because `join_schema` may contain some column which don't exist in `project schema`



##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1239,15 +1239,10 @@ pub fn project(
         }
     }
     validate_unique_names("Projections", projected_expr.iter())?;
-    let input_schema = DFSchema::new_with_metadata(
-        exprlist_to_fields(&projected_expr, &plan)?,
-        plan.schema().metadata().clone(),
-    )?;

Review Comment:
   it already was contained by `try_new_with_schema`, so we can use `try_new_with_schema` directly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jackwener closed pull request #6824: minor: with_inputs() can use original schema.

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener closed pull request #6824: minor: with_inputs() can use original schema.
URL: https://github.com/apache/arrow-datafusion/pull/6824


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jackwener commented on pull request #6824: minor: with_inputs() can use original schema.

["jackwener (via GitHub)" <gi...@apache.org>]

jackwener commented on PR #6824:
URL: https://github.com/apache/arrow-datafusion/pull/6824#issuecomment-1618539558

   ``


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org