You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "liurenjie1024 (via GitHub)" <gi...@apache.org> on 2024/03/11 10:17:56 UTC
[I] Implement `PruneColumns` for `Schema`. [iceberg-rust]
liurenjie1024 opened a new issue, #251:
URL: https://github.com/apache/iceberg-rust/issues/251
See [java implementation](https://github.com/apache/iceberg/blob/c07f2aabc0a1d02f068ecf1514d2479c0fbdd3b0/api/src/main/java/org/apache/iceberg/types/PruneColumns.java#L42).
It's useful in schema projection, id projection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Implement `PruneColumns` for `Schema`. [iceberg-rust]
Posted by "Dysprosium0626 (via GitHub)" <gi...@apache.org>.
Dysprosium0626 commented on issue #251:
URL: https://github.com/apache/iceberg-rust/issues/251#issuecomment-1991812879
Hi @viirya @liurenjie1024 , Can I help with this issue and I have nearly completing implement `PruneColumn` for Schema.
See https://github.com/Dysprosium0626/iceberg-rust/commit/8295f83496a8cb60301cbbfa4c7432bb0ad49fd3. Currently I just need to add some test cases but I have no ideas(cuz it seems that there is no corresponding test cases in Java implementation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Implement `PruneColumns` for `Schema`. [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #251:
URL: https://github.com/apache/iceberg-rust/issues/251#issuecomment-1992924747
@Dysprosium0626 Yes, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Implement `PruneColumns` for `Schema`. [iceberg-rust]
Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #251:
URL: https://github.com/apache/iceberg-rust/issues/251#issuecomment-1992383664
If you are looking for tests, we have them on PyIceberg: https://github.com/apache/iceberg-python/blob/0ee7f1233e062b17b03fccc1eac6449c72e575f0/tests/test_schema.py#L564-L819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Implement `PruneColumns` for `Schema`. [iceberg-rust]
Posted by "Dysprosium0626 (via GitHub)" <gi...@apache.org>.
Dysprosium0626 commented on issue #251:
URL: https://github.com/apache/iceberg-rust/issues/251#issuecomment-2019320012
Hi @liurenjie1024, thanks for your review. This issue can be closed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Implement `PruneColumns` for `Schema`. [iceberg-rust]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on issue #251:
URL: https://github.com/apache/iceberg-rust/issues/251#issuecomment-1992036933
Of course, yes. I plan to implement this but as you are close to finish it. I can help review once you submit the PR. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Implement `PruneColumns` for `Schema`. [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 closed issue #251: Implement `PruneColumns` for `Schema`.
URL: https://github.com/apache/iceberg-rust/issues/251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org