Re: Review notification bot

[Hyukjin Kwon <gu...@gmail.com>]

(BTW, seems not turned off yet -
https://github.com/apache/spark/pull/21939#issuecomment-409412805)

2018년 8월 1일 (수) 오전 2:24, Sean Owen <sr...@gmail.com>님이 작성:

> I haven't been pinged by this bot :( :)
>
> But I do like this comments on PRs: like
> https://github.com/apache/spark/pull/21925#issuecomment-409035244
>
> Is the issue that @-mentions cause emails too?
>
> Is there any option to maybe only consider pinging someone if they've
> touched the code within the last N months?
>
> On Tue, Jul 31, 2018 at 2:31 AM Hyukjin Kwon <gu...@gmail.com> wrote:
>
>> > I originally did that, but GitHub told me I could only have one
>> personal and one bot account. If someone else registered the
>> spark-mention-bot I'd be happy to switch it to that.
>>
>> I have my own spare account for testing purpose (spark-test).
>> https://github.com/spark-test I don't mind sharing it.
>>
>>
>> Since at least people see some issues (+potential issues about false
>> positive too) for the current status, I hope pausing it could be considered
>> as an option for now.
>> I see few things so far which should kindly be considered:
>>
>>   1. Some people actually could get annoyed by the automatic ping
>>   2. Should reflect the resent changes (given Felix's
>> https://github.com/apache/spark/pull/21928#issuecomment-409100200)
>>   3. Activeness should be concerned
>>   4. Blacklist the existing PMC (or add a rate limit)
>>   5. Non-committers look not pinged given my observation
>>   6. It is completely optional and it's rather something committer should regularly
>> - this could imply we don't have enough active committers.
>>
>>>
>>>