[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4413: systemvm: fix proc.find in CsProcess.py

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #4413:
URL: https://github.com/apache/cloudstack/pull/4413#discussion_r507753867



##########
File path: systemvm/debian/opt/cloud/bin/cs/CsProcess.py
##########
@@ -40,9 +40,9 @@ def kill_all(self):
 
     def find_pid(self):
         self.pid = []
+        items = len(self.search)
         for i in CsHelper.execute("ps aux"):
-            items = len(self.search)
-            proc = re.split(r"\s+", i)[items*-1:]
+            proc = re.split(r"\s+", i)[10:]

Review comment:
       given this is null based the return is now the full cli as returned by `ps aux` ; :+1: 

##########
File path: systemvm/debian/opt/cloud/bin/cs/CsProcess.py
##########
@@ -40,9 +40,9 @@ def kill_all(self):
 
     def find_pid(self):
         self.pid = []
+        items = len(self.search)

Review comment:
       maybe we should think about renaming search; it actually means to be the process/command name.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org