You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by computerlove <gi...@git.apache.org> on 2018/07/18 12:22:44 UTC
[GitHub] lucene-solr pull request #421: SOLR-7557: Fix parsing of child documents usi...
GitHub user computerlove opened a pull request:
https://github.com/apache/lucene-solr/pull/421
SOLR-7557: Fix parsing of child documents using queryAndStreamResponse
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nvdb-vegdata/lucene-solr master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/421.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #421
----
commit 5d92f332dd42504485d85b7399f8bef7b3e02375
Author: Marvin Bredal Lillehaug <ma...@...>
Date: 2018-07-18T12:21:51Z
SOLR-7557: Fix parsing of child documents using queryAndStreamResponse
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #421: SOLR-7557: Fix parsing of child documents using quer...
Posted by janhoy <gi...@git.apache.org>.
Github user janhoy commented on the issue:
https://github.com/apache/lucene-solr/pull/421
Great. What's the reason for adding another child document to the test?
Please do the following changes
* Move the test to `SolrExampleStreamingBinaryTest` (don't need to test it for all clients
* Rename the test `testQueryAndStreamResponse` as it is the response parsing we're testing
* Add this line in `solr/CHANGES.txt` under 7.6.0 version and section "Bug Fixes" (appx line 215)
* SOLR-7557: Fix parsing of child documents using queryAndStreamResponse (Marvin Bredal Lillehaug via janhoy)
* Make sure the PR is up-to-date with current master
Then I'll be able to merge it directly and you also get credit in git log :)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #421: SOLR-7557: Fix parsing of child documents using quer...
Posted by computerlove <gi...@git.apache.org>.
Github user computerlove commented on the issue:
https://github.com/apache/lucene-solr/pull/421
I had some rebase/merge problems, getting a very large diff. Tried several times to fix it and keep the commit history for this issue, but ended up having to just apply the patch to a clean master.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #421: SOLR-7557: Fix parsing of child documents using quer...
Posted by computerlove <gi...@git.apache.org>.
Github user computerlove commented on the issue:
https://github.com/apache/lucene-solr/pull/421
Damn. Now it's there!
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr pull request #421: SOLR-7557: Fix parsing of child documents usi...
Posted by computerlove <gi...@git.apache.org>.
Github user computerlove closed the pull request at:
https://github.com/apache/lucene-solr/pull/421
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #421: SOLR-7557: Fix parsing of child documents using quer...
Posted by janhoy <gi...@git.apache.org>.
Github user janhoy commented on the issue:
https://github.com/apache/lucene-solr/pull/421
Probably the easiest :) Thanks
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #421: SOLR-7557: Fix parsing of child documents using quer...
Posted by janhoy <gi...@git.apache.org>.
Github user janhoy commented on the issue:
https://github.com/apache/lucene-solr/pull/421
Hmm, your new commit lacks the changes to the `StreamingBinaryResponseParser` file.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[GitHub] lucene-solr issue #421: SOLR-7557: Fix parsing of child documents using quer...
Posted by janhoy <gi...@git.apache.org>.
Github user janhoy commented on the issue:
https://github.com/apache/lucene-solr/pull/421
Committed. You may close this PR (forgot to add the magic words in the commit msg)
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org