You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hugegraph.apache.org by "javeme (via GitHub)" <gi...@apache.org> on 2023/02/08 14:01:48 UTC
[GitHub] [incubator-hugegraph-doc] javeme commented on a diff in pull request #189: Update validate-release.md with non-interactive mode
javeme commented on code in PR #189:
URL: https://github.com/apache/incubator-hugegraph-doc/pull/189#discussion_r1100175828
##########
content/en/docs/contribution-guidelines/validate-release.md:
##########
@@ -55,19 +55,26 @@ gpg --import KEYS
# After importing, you can see the following output, which means that 3 user public keys have been imported
gpg: /home/ubuntu/.gnupg/trustdb.gpg: trustdb created
-gpg: key B78B058CC255F6DC: public key "Imba Jin (apache mail) <ji...@apache.org>" imported
+gpg: key BA7E78F8A81A885E: public key "imbajin (apache mail) <ji...@apache.org>" imported
gpg: key 818108E7924549CC: public key "vaughn <va...@apache.org>" imported
gpg: key 28DCAED849C4180E: public key "coderzc (CODE SIGNING KEY) <zh...@apache.org>" imported
gpg: Total number processed: 3
gpg: imported: 3
-# 2. Trust release users (here you need to trust 3 users, perform the same operation for Imba Jin, vaughn, coderzc in turn)
-gpg --edit-key Imba Jin # Take the first one as an example, enter the interactive mode
+# 2. Trust release users (you need trust x username mentioned in voting mail, if more than 1 user, just repeat the steps in turn or use script)
Review Comment:
"you need to trust n usernames..."
##########
content/cn/docs/contribution-guidelines/validate-release.md:
##########
@@ -56,19 +56,25 @@ gpg --import KEYS
# 导入后可以看到如下输出, 这代表导入了 3 个用户公钥
gpg: /home/ubuntu/.gnupg/trustdb.gpg: trustdb created
-gpg: key B78B058CC255F6DC: public key "Imba Jin (apache mail) <ji...@apache.org>" imported
+gpg: key BA7E78F8A81A885E: public key "imbajin (apache mail) <ji...@apache.org>" imported
gpg: key 818108E7924549CC: public key "vaughn <va...@apache.org>" imported
gpg: key 28DCAED849C4180E: public key "coderzc (CODE SIGNING KEY) <zh...@apache.org>" imported
gpg: Total number processed: 3
gpg: imported: 3
-# 2. 信任发版用户 (这里需要信任 3 个, 对 Imba Jin, vaughn, coderzc 依次执行相同操作)
-gpg --edit-key Imba Jin # 以第一个为例, 进入交互模式
+# 2. 信任发版用户 (你需要信任 x 个邮件里提到的 gpg 用户名, ＞1则依次执行相同操作)
Review Comment:
x => n
##########
content/en/docs/contribution-guidelines/validate-release.md:
##########
@@ -55,19 +55,26 @@ gpg --import KEYS
# After importing, you can see the following output, which means that 3 user public keys have been imported
gpg: /home/ubuntu/.gnupg/trustdb.gpg: trustdb created
-gpg: key B78B058CC255F6DC: public key "Imba Jin (apache mail) <ji...@apache.org>" imported
+gpg: key BA7E78F8A81A885E: public key "imbajin (apache mail) <ji...@apache.org>" imported
gpg: key 818108E7924549CC: public key "vaughn <va...@apache.org>" imported
gpg: key 28DCAED849C4180E: public key "coderzc (CODE SIGNING KEY) <zh...@apache.org>" imported
gpg: Total number processed: 3
gpg: imported: 3
-# 2. Trust release users (here you need to trust 3 users, perform the same operation for Imba Jin, vaughn, coderzc in turn)
-gpg --edit-key Imba Jin # Take the first one as an example, enter the interactive mode
+# 2. Trust release users (you need trust x username mentioned in voting mail, if more than 1 user, just repeat the steps in turn or use script)
Review Comment:
`or use script` means what?
##########
content/cn/docs/contribution-guidelines/validate-release.md:
##########
@@ -56,19 +56,25 @@ gpg --import KEYS
# 导入后可以看到如下输出, 这代表导入了 3 个用户公钥
gpg: /home/ubuntu/.gnupg/trustdb.gpg: trustdb created
-gpg: key B78B058CC255F6DC: public key "Imba Jin (apache mail) <ji...@apache.org>" imported
+gpg: key BA7E78F8A81A885E: public key "imbajin (apache mail) <ji...@apache.org>" imported
gpg: key 818108E7924549CC: public key "vaughn <va...@apache.org>" imported
gpg: key 28DCAED849C4180E: public key "coderzc (CODE SIGNING KEY) <zh...@apache.org>" imported
gpg: Total number processed: 3
gpg: imported: 3
-# 2. 信任发版用户 (这里需要信任 3 个, 对 Imba Jin, vaughn, coderzc 依次执行相同操作)
-gpg --edit-key Imba Jin # 以第一个为例, 进入交互模式
+# 2. 信任发版用户 (你需要信任 x 个邮件里提到的 gpg 用户名, ＞1则依次执行相同操作)
+gpg --edit-key $USER # 这里填写具体用户名或者公钥串, 回车进入交互模式
gpg> trust
...输出选项..
Your decision? 5 #选择5
Review Comment:
增加空格 `\# 选择5`
##########
content/en/docs/contribution-guidelines/validate-release.md:
##########
@@ -55,19 +55,26 @@ gpg --import KEYS
# After importing, you can see the following output, which means that 3 user public keys have been imported
gpg: /home/ubuntu/.gnupg/trustdb.gpg: trustdb created
-gpg: key B78B058CC255F6DC: public key "Imba Jin (apache mail) <ji...@apache.org>" imported
+gpg: key BA7E78F8A81A885E: public key "imbajin (apache mail) <ji...@apache.org>" imported
gpg: key 818108E7924549CC: public key "vaughn <va...@apache.org>" imported
gpg: key 28DCAED849C4180E: public key "coderzc (CODE SIGNING KEY) <zh...@apache.org>" imported
gpg: Total number processed: 3
gpg: imported: 3
-# 2. Trust release users (here you need to trust 3 users, perform the same operation for Imba Jin, vaughn, coderzc in turn)
-gpg --edit-key Imba Jin # Take the first one as an example, enter the interactive mode
+# 2. Trust release users (you need trust x username mentioned in voting mail, if more than 1 user, just repeat the steps in turn or use script)
Review Comment:
"if more than one user"
##########
content/en/docs/contribution-guidelines/validate-release.md:
##########
@@ -55,19 +55,26 @@ gpg --import KEYS
# After importing, you can see the following output, which means that 3 user public keys have been imported
gpg: /home/ubuntu/.gnupg/trustdb.gpg: trustdb created
-gpg: key B78B058CC255F6DC: public key "Imba Jin (apache mail) <ji...@apache.org>" imported
+gpg: key BA7E78F8A81A885E: public key "imbajin (apache mail) <ji...@apache.org>" imported
gpg: key 818108E7924549CC: public key "vaughn <va...@apache.org>" imported
gpg: key 28DCAED849C4180E: public key "coderzc (CODE SIGNING KEY) <zh...@apache.org>" imported
gpg: Total number processed: 3
gpg: imported: 3
-# 2. Trust release users (here you need to trust 3 users, perform the same operation for Imba Jin, vaughn, coderzc in turn)
-gpg --edit-key Imba Jin # Take the first one as an example, enter the interactive mode
+# 2. Trust release users (you need trust x username mentioned in voting mail, if more than 1 user, just repeat the steps in turn or use script)
+gpg --edit-key $USER # input the username, enter the interactive mode
gpg> trust
...output options..
Your decision? 5 #select five
Review Comment:
`# select 5 here`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@hugegraph.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org