[jira] [Commented] (PIG-5268) Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage

["Nandor Kollar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PIG-5268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068819#comment-16068819 ] 

Nandor Kollar commented on PIG-5268:
------------------------------------

Thanks for refactoring this! I've three comments, could you please address these:
- could you please rename EMPTY to EMPTY_HPATH, it is more a descriptive name
- in init method, it looks like nameNode variable is not used at all, wondering what is the intent of that variable?
- this class uses two deprecated methods on DistributedFileSystem: getRawCapacity and getRawUsed. The javadoc of these methods states that org.apache.hadoop.fs.FileSystem#getStatus() should be used instead, if this an easy fix, could you please replace these deprecated calls with the proper replacement calls?

Otherwise looks good to me.

> Review of org.apache.pig.backend.hadoop.datastorage.HDataStorage
> ----------------------------------------------------------------
>
>                 Key: PIG-5268
>                 URL: https://issues.apache.org/jira/browse/PIG-5268
>             Project: Pig
>          Issue Type: Improvement
>          Components: data
>    Affects Versions: 0.17.0
>            Reporter: BELUGA BEHR
>            Priority: Trivial
>         Attachments: PIG-5268.1.patch
>
>
> # Optimize for case where {{asCollection}} is empty
> # Tidy up



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)