You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Toshihiro Suzuki (JIRA)" <ji...@apache.org> on 2018/12/18 02:03:00 UTC

[jira] [Commented] (HBASE-21610) numOpenConnections metric is set to -1 when zero server channel exist

    [ https://issues.apache.org/jira/browse/HBASE-21610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723585#comment-16723585 ] 

Toshihiro Suzuki commented on HBASE-21610:
------------------------------------------

+1

> numOpenConnections metric is set to -1 when zero server channel exist
> ---------------------------------------------------------------------
>
>                 Key: HBASE-21610
>                 URL: https://issues.apache.org/jira/browse/HBASE-21610
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 2.1.1, 2.0.3
>            Reporter: Pankaj Kumar
>            Assignee: Pankaj Kumar
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: HBASE-21610.patch
>
>
> In NettyRpcServer, numOpenConnections metric is set to -1 when zero server channel exist.
> {code}
> @Override
>  public int getNumOpenConnections() {
>  // allChannels also contains the server channel, so exclude that from the count.
>  return allChannels.size() - 1;
>  }
> {code}
>  
>  We should not decrease the channel size by 1 when zero server channel exist.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)