You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rdblue (via GitHub)" <gi...@apache.org> on 2023/03/08 15:47:13 UTC

[GitHub] [iceberg] rdblue commented on pull request #7011: Core: Store split offset for delete files

rdblue commented on PR #7011:
URL: https://github.com/apache/iceberg/pull/7011#issuecomment-1460372628

   This looks fine to me overall, but I'd prefer to use `ImmutableList` or `long[]` for split offsets in the builder to avoid an unnecessary new util class and copy method.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org