You are viewing a plain text version of this content. The canonical link for it is here.
Posted to axis-cvs@ws.apache.org by ga...@apache.org on 2004/06/21 23:23:30 UTC

cvs commit: ws-axis/java/src/org/apache/axis/message RPCElement.java SOAPDocumentImpl.java

gawor       2004/06/21 14:23:30

  Modified:    java/src/org/apache/axis/message RPCElement.java
                        SOAPDocumentImpl.java
  Log:
  minor NPE bugs found with FindBugs tool
  
  Revision  Changes    Path
  1.91      +1 -1      ws-axis/java/src/org/apache/axis/message/RPCElement.java
  
  Index: RPCElement.java
  ===================================================================
  RCS file: /home/cvs/ws-axis/java/src/org/apache/axis/message/RPCElement.java,v
  retrieving revision 1.90
  retrieving revision 1.91
  diff -u -r1.90 -r1.91
  --- RPCElement.java	25 Feb 2004 14:02:42 -0000	1.90
  +++ RPCElement.java	21 Jun 2004 21:23:30 -0000	1.91
  @@ -70,7 +70,7 @@
   
                   String lc = Utils.xmlNameToJava(name);
                   if (serviceDesc == null) {
  -                    AxisFault.makeFault(
  +                    throw AxisFault.makeFault(
                               new ClassNotFoundException(
                                       Messages.getMessage("noClassForService00",
                                                            lc)));
  
  
  
  1.5       +3 -3      ws-axis/java/src/org/apache/axis/message/SOAPDocumentImpl.java
  
  Index: SOAPDocumentImpl.java
  ===================================================================
  RCS file: /home/cvs/ws-axis/java/src/org/apache/axis/message/SOAPDocumentImpl.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- SOAPDocumentImpl.java	25 Feb 2004 14:02:43 -0000	1.4
  +++ SOAPDocumentImpl.java	21 Jun 2004 21:23:30 -0000	1.5
  @@ -323,7 +323,7 @@
                   SOAPBody body =
                       (org.apache.axis.message.SOAPBody) soapEnv.getHeader();
                   if (body != null) {
  -                    return header.getElementsByTagNameNS(
  +                    return body.getElementsByTagNameNS(
                               namespaceURI,
                               localName);
                   }
  @@ -352,9 +352,9 @@
                       return header.getElementsByTagName(localName);
                   }
                   SOAPBody body =
  -                    (org.apache.axis.message.SOAPBody) soapEnv.getHeader();
  +                    (org.apache.axis.message.SOAPBody) soapEnv.getBody();
                   if (body != null) {
  -                    return header.getElementsByTagName(localName);
  +                    return body.getElementsByTagName(localName);
                   }
               }
               return null;