You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/06/24 23:50:03 UTC
Review Request 22945: Fixed FrameworkReregistersFirst and
SlaveReregistersFirst allocator tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22945/
-----------------------------------------------------------
Review request for mesos, Dominic Hamon and Jiang Yan Xu.
Bugs: MESOS-1514 and MESOS-1532
https://issues.apache.org/jira/browse/MESOS-1514
https://issues.apache.org/jira/browse/MESOS-1532
Repository: mesos-git
Description
-------
The bug was that the tests were not waiting for acks to be received by slave causing the slave to retry on master failover.
Diffs
-----
src/tests/allocator_zookeeper_tests.cpp 1f15cf5312e67774a7dc4443d605e45103601343
Diff: https://reviews.apache.org/r/22945/diff/
Testing
-------
./bin/mesos-tests.sh --gtest_filter="*ReregistersFirst*" --gtest_break_on_failure --gtest_repeat=-1 --verbose
Thanks,
Vinod Kone
Re: Review Request 22945: Fixed FrameworkReregistersFirst and
SlaveReregistersFirst allocator tests.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22945/#review46584
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On June 24, 2014, 2:50 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22945/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 2:50 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Jiang Yan Xu.
>
>
> Bugs: MESOS-1514 and MESOS-1532
> https://issues.apache.org/jira/browse/MESOS-1514
> https://issues.apache.org/jira/browse/MESOS-1532
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The bug was that the tests were not waiting for acks to be received by slave causing the slave to retry on master failover.
>
>
> Diffs
> -----
>
> src/tests/allocator_zookeeper_tests.cpp 1f15cf5312e67774a7dc4443d605e45103601343
>
> Diff: https://reviews.apache.org/r/22945/diff/
>
>
> Testing
> -------
>
> ./bin/mesos-tests.sh --gtest_filter="*ReregistersFirst*" --gtest_break_on_failure --gtest_repeat=-1 --verbose
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 22945: Fixed FrameworkReregistersFirst and
SlaveReregistersFirst allocator tests.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22945/#review46586
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On June 24, 2014, 2:50 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22945/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 2:50 p.m.)
>
>
> Review request for mesos, Dominic Hamon and Jiang Yan Xu.
>
>
> Bugs: MESOS-1514 and MESOS-1532
> https://issues.apache.org/jira/browse/MESOS-1514
> https://issues.apache.org/jira/browse/MESOS-1532
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The bug was that the tests were not waiting for acks to be received by slave causing the slave to retry on master failover.
>
>
> Diffs
> -----
>
> src/tests/allocator_zookeeper_tests.cpp 1f15cf5312e67774a7dc4443d605e45103601343
>
> Diff: https://reviews.apache.org/r/22945/diff/
>
>
> Testing
> -------
>
> ./bin/mesos-tests.sh --gtest_filter="*ReregistersFirst*" --gtest_break_on_failure --gtest_repeat=-1 --verbose
>
>
> Thanks,
>
> Vinod Kone
>
>