You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ru...@apache.org on 2026/08/20 07:39:41 UTC
(superset) branch adopt/lineage-visualization updated: fix(lineage): resolve CI failures (lint, navigation, test typo)
This is an automated email from the ASF dual-hosted git repository.
rusackas pushed a commit to branch adopt/lineage-visualization
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/adopt/lineage-visualization by this push:
new 45e434c07ea fix(lineage): resolve CI failures (lint, navigation, test typo)
45e434c07ea is described below
commit 45e434c07ea8565d05b33c0bb278dbcaa6478a33
Author: rusackas <ev...@rusackas.com>
AuthorDate: Thu Aug 20 00:39:26 2026 -0700
fix(lineage): resolve CI failures (lint, navigation, test typo)
Merges duplicate @superset-ui/core/components import, replaces direct
window.location navigation with the redirect() helper and drops the
hard-coded /superset/ dashboard path per navigationUtils invariants,
and fixes new drill_info RBAC tests calling insert_dataset() with a
nonexistent owners kwarg instead of editor_user_ids.
Co-Authored-By: Claude Opus 4.8 <no...@anthropic.com>
---
superset-frontend/src/features/lineage/LineageView.tsx | 8 ++++----
tests/integration_tests/datasets/api_tests.py | 12 ++++++------
2 files changed, 10 insertions(+), 10 deletions(-)
diff --git a/superset-frontend/src/features/lineage/LineageView.tsx b/superset-frontend/src/features/lineage/LineageView.tsx
index 0fe07ad9f8b..151aca401c9 100644
--- a/superset-frontend/src/features/lineage/LineageView.tsx
+++ b/superset-frontend/src/features/lineage/LineageView.tsx
@@ -20,10 +20,10 @@ import { FC, useMemo, useState, useCallback } from 'react';
import { useResizeDetector } from 'react-resize-detector';
import { t } from '@apache-superset/core/translation';
import { styled, useTheme } from '@apache-superset/core/theme';
-import { Empty, Loading } from '@superset-ui/core/components';
-import { Button } from '@superset-ui/core/components';
+import { Button, Empty, Loading } from '@superset-ui/core/components';
import { ResourceStatus } from 'src/hooks/apiResources/apiResources';
import type { Resource } from 'src/hooks/apiResources/apiResources';
+import { redirect } from 'src/utils/navigationUtils';
import type {
DatasetLineage,
ChartLineage,
@@ -646,7 +646,7 @@ const LineageView: FC<LineageViewProps> = ({ lineageResource, entityType }) => {
const getEntityUrl = (nodeDetails: NodeDetails): string => {
switch (nodeDetails.type) {
case 'dashboard':
- return `/superset/dashboard/${nodeDetails.id}/`;
+ return `/dashboard/${nodeDetails.id}/`;
case 'chart':
return `/explore/?slice_id=${nodeDetails.id}`;
default:
@@ -692,7 +692,7 @@ const LineageView: FC<LineageViewProps> = ({ lineageResource, entityType }) => {
buttonStyle="primary"
buttonSize="small"
onClick={() => {
- window.location.href = getEntityUrl(selectedNode);
+ redirect(getEntityUrl(selectedNode));
}}
>
{t('Open')}{' '}
diff --git a/tests/integration_tests/datasets/api_tests.py b/tests/integration_tests/datasets/api_tests.py
index 429a406f3d5..ad2ffc185e2 100644
--- a/tests/integration_tests/datasets/api_tests.py
+++ b/tests/integration_tests/datasets/api_tests.py
@@ -366,8 +366,8 @@ class TestDatasetApi(SupersetTestCase):
"""
Dataset API: Test get dataset list with invalid JWT authentication
"""
- client = self.create_app().test_client()
- rv = client.get(
+ test_client = self.create_app().test_client()
+ rv = test_client.get(
"api/v1/dataset/",
headers={"Authorization": "Bearer not-a-token"},
)
@@ -3654,7 +3654,7 @@ class TestDatasetApi(SupersetTestCase):
self.login(ADMIN_USERNAME)
dataset = self.insert_dataset(
table_name="test_rbac_dataset",
- owners=[],
+ editor_user_ids=[],
columns=[
TableColumn(
column_name="restricted_column",
@@ -3711,7 +3711,7 @@ class TestDatasetApi(SupersetTestCase):
dataset = self.insert_dataset(
table_name="test_rbac_dataset_denied",
- owners=[],
+ editor_user_ids=[],
columns=[
TableColumn(
column_name="restricted_column",
@@ -3749,7 +3749,7 @@ class TestDatasetApi(SupersetTestCase):
"""
dataset = self.insert_dataset(
table_name="test_rbac_dataset_denied",
- owners=[],
+ editor_user_ids=[],
columns=[
TableColumn(
column_name="restricted_column",
@@ -3795,7 +3795,7 @@ class TestDatasetApi(SupersetTestCase):
dataset = self.insert_dataset(
table_name="test_no_dashboard_id",
- owners=[],
+ editor_user_ids=[],
columns=[
TableColumn(
column_name="restricted_column",