You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/29 20:53:19 UTC

[GitHub] [incubator-superset] nytai commented on a change in pull request #11496: chore: Cleaning up ENABLE_REACT_CRUD_VIEWS config

nytai commented on a change in pull request #11496:
URL: https://github.com/apache/incubator-superset/pull/11496#discussion_r514559596



##########
File path: superset/config.py
##########
@@ -849,11 +849,6 @@ class CeleryConfig:  # pylint: disable=too-few-public-methods
 DOCUMENTATION_TEXT = "Documentation"
 DOCUMENTATION_ICON = None  # Recommended size: 16x16
 
-# Enables the replacement react views for all the FAB views (list, edit, show) with
-# designs introduced in SIP-34: https://github.com/apache/incubator-superset/issues/8976
-# This is a work in progress so not all features available in FAB have been implemented

Review comment:
       Should we move these comments to the feature flag lines? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org