You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/01/29 20:42:04 UTC
Review Request 42971: stout: Mark an unused function parameter
appropriately.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42971/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos
Description
-------
stout: Mark an unused function parameter appropriately.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp a3dc7697f5f041a503e4aa84df67c915c43b76b5
Diff: https://reviews.apache.org/r/42971/diff/
Testing
-------
make check
Thanks,
Neil Conway
Re: Review Request 42971: stout: Mark an unused function parameter
appropriately.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42971/#review116992
-----------------------------------------------------------
Ship it!
Ship It!
- Anand Mazumdar
On Jan. 29, 2016, 7:42 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42971/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2016, 7:42 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> stout: Mark an unused function parameter appropriately.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp a3dc7697f5f041a503e4aa84df67c915c43b76b5
>
> Diff: https://reviews.apache.org/r/42971/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42971: Marked an unused function parameter
appropriately in stout.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42971/#review117415
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 1, 2016, 10:08 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42971/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2016, 10:08 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Marked an unused function parameter appropriately in stout.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp a3dc7697f5f041a503e4aa84df67c915c43b76b5
>
> Diff: https://reviews.apache.org/r/42971/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 42971: Marked an unused function parameter
appropriately in stout.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42971/
-----------------------------------------------------------
(Updated Feb. 1, 2016, 10:08 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Fix commit message style
Summary (updated)
-----------------
Marked an unused function parameter appropriately in stout.
Repository: mesos
Description (updated)
-------
Marked an unused function parameter appropriately in stout.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp a3dc7697f5f041a503e4aa84df67c915c43b76b5
Diff: https://reviews.apache.org/r/42971/diff/
Testing
-------
make check
Thanks,
Neil Conway