[GitHub] [airflow] dstandish commented on a change in pull request #14152: Helm RBAC Best Practices

[GitBox <gi...@apache.org>]

dstandish commented on a change in pull request #14152:
URL: https://github.com/apache/airflow/pull/14152#discussion_r573457512



##########
File path: chart/templates/_helpers.yaml
##########
@@ -361,6 +387,105 @@ server_tls_key_file = /etc/pgbouncer/server.key
 {{ (printf "%s-airflow-config" .Release.Name) }}
 {{- end }}
 
+{{/*
+Create the name of the webserver service account to use
+*/}}
+{{- define "webserver.serviceAccountName" -}}
+{{- if .Values.webserver.serviceAccount.create -}}
+    {{ default (printf "%s-webserver" (include "airflow.fullname" .)) .Values.webserver.serviceAccount.name }}
+{{- else -}}
+    {{ default "default" .Values.webserver.serviceAccount.name }}
+{{- end -}}
+{{- end -}}

Review comment:
       is it possible to create all of these svc accts with a loop, to avoid some repetition?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org