[jira] Commented: (PLUTO-558) Change FilterManagerService to use portlet entity

["Ate Douma (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PLUTO-558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705543#action_12705543 ] 

Ate Douma commented on PLUTO-558:
---------------------------------

Carsten,

While I've no objections to allowing more fine-grained configuration and handling of filtering, I'm not so sure the PortletEntity is the right level for this.
Are you sure you want this to be differentiated only on the PreferencesSet used by the Portlet(Window)?
I would suggest using PortletWindow instead of PortletEntity.
Currently we have PortletWindow -> PortletEntity -> PortletDefinition -> portlet name, so using PortletWindow allows even finer grained configuration.

Furthermore, I'm actually tempted to propose we drop PortletEntity as a qualified interface all together as Pluto (nor Jetspeed) doesn't use PortletEntity at all.
For Jetspeed,  I've already enhanced our (extended) PortletWindow to provide access to the PortletEntity (PreferencesSet) *ID* with method String getPortletEntityId() and also added getPortletDefinition() directly to PortletWindow.
That greatly cleans up the code base as the PortletEntity 'intermediate' (now reduced to just an empty interface) then can be cut out from all the PortletWindow->PortletDefinition access usages.
WDYT?



> Change FilterManagerService to use portlet entity
> -------------------------------------------------
>
>                 Key: PLUTO-558
>                 URL: https://issues.apache.org/jira/browse/PLUTO-558
>             Project: Pluto
>          Issue Type: Improvement
>          Components: portlet container
>    Affects Versions: 2.0.0
>            Reporter: Carsten Ziegeler
>            Assignee: Carsten Ziegeler
>             Fix For: 2.0.0
>
>
> the current FilterManagerService interface uses the
> PortletApplicationDefinition and the portlet name (string):
> getFilterManager(PortletApplicationDefinition portletAppDD, String
> portletName, String lifeCycle)
> I would like to change the signature of this method to use the
> PortletEntity:
> getFilterManager(PortletEntity, String lifeCycle).
> This would allow portals to provide different filter chains based on a
> portlet entity.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.