[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8787: Cleanup Kinesis Logs

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #8787:
URL: https://github.com/apache/pinot/pull/8787#discussion_r887192421


##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConsumer.java:
##########
@@ -159,23 +159,23 @@ private KinesisRecordsBatch getResult(StreamPartitionMsgOffset startOffset, Stre
 
       return new KinesisRecordsBatch(recordList, startShardToSequenceNum.getKey(), isEndOfShard);
     } catch (IllegalStateException e) {
-      LOGGER.warn("Illegal state exception, connection is broken", e);
+      debugAndLogWarning("Illegal state exception, connection is broken", e);
       return handleException(kinesisStartCheckpoint, recordList);
     } catch (ProvisionedThroughputExceededException e) {
-      LOGGER.warn("The request rate for the stream is too high", e);
+      debugAndLogWarning("The request rate for the stream is too high", e);
       return handleException(kinesisStartCheckpoint, recordList);
     } catch (ExpiredIteratorException e) {
-      LOGGER.warn("ShardIterator expired while trying to fetch records", e);
+      debugAndLogWarning("ShardIterator expired while trying to fetch records", e);
       return handleException(kinesisStartCheckpoint, recordList);
     } catch (ResourceNotFoundException | InvalidArgumentException e) {
       // aws errors
-      LOGGER.error("Encountered AWS error while attempting to fetch records", e);
+      LOGGER.error("Encountered AWS error while attempting to fetch records: {}", e.getMessage());

Review Comment:
   Should we keep the stack trace here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org