[jira] [Commented] (KAFKA-15639) Investigate ConsumerNetworkThreadTest's testResetPositionsProcessFailureIsIgnored

["Colin McCabe (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-15639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17877834#comment-17877834 ] 

Colin McCabe commented on KAFKA-15639:
--------------------------------------

Changing target fix version to 4.0 since this is not a blocker and we are past code freeze

> Investigate ConsumerNetworkThreadTest's testResetPositionsProcessFailureIsIgnored
> ---------------------------------------------------------------------------------
>
>                 Key: KAFKA-15639
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15639
>             Project: Kafka
>          Issue Type: Test
>          Components: clients, consumer, unit tests
>            Reporter: Kirk True
>            Priority: Minor
>              Labels: consumer-threading-refactor, unit-tests
>             Fix For: 3.9.0
>
>
> The {{testResetPositionsProcessFailureIsIgnored}} test looks like this:
>  
> {code:java}
>     @Test
>     public void testResetPositionsProcessFailureIsIgnored() {
>         doThrow(new NullPointerException()).when(offsetsRequestManager).resetPositionsIfNeeded();
>         ResetPositionsApplicationEvent event = new ResetPositionsApplicationEvent();
>         applicationEventsQueue.add(event);
>         assertDoesNotThrow(() -> consumerNetworkThread.runOnce());
>         verify(applicationEventProcessor).process(any(ResetPositionsApplicationEvent.class));
>     }
>  {code}
>  
> [~junrao] asks:
>  
> {quote}Not sure if this is a useful test since {{offsetsRequestManager.resetPositionsIfNeeded()}} seems to never directly throw an exception?
> {quote}
>  
> I commented out the {{doThrow}} line and it did not impact the test. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)