[jira] [Commented] (SAMZA-28) Use gauge instead of counter for bufferedMessageCountMap

["Jakob Homan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SAMZA-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13788448#comment-13788448 ] 

Jakob Homan commented on SAMZA-28:
----------------------------------

+1

> Use gauge instead of counter for bufferedMessageCountMap
> --------------------------------------------------------
>
>                 Key: SAMZA-28
>                 URL: https://issues.apache.org/jira/browse/SAMZA-28
>             Project: Samza
>          Issue Type: Bug
>          Components: container, metrics
>    Affects Versions: 0.6.0
>            Reporter: Chris Riccomini
>            Assignee: Chris Riccomini
>             Fix For: 0.7.0
>
>         Attachments: SAMZA-28.0.patch, SAMZA-28.1.patch, SAMZA-28.2.patch, samza-buffered-messages-metric.png
>
>
> The bufferedMessageCountMap variable in BlockingEnvelopeMapMetrics currently uses counters to keep track of the number of messages in a SystemStreamPartition's queue. bufferedMessageCountMap is meant to say, "There are N messages buffered for SystemStreamPartition X at time T." This variable does not do this, since we are using a counter, not a gauge. We should switch the map to uses Gauge instead of Counter. We'll need to update decBufferedMessageCount and incBufferedMessageCount accordingly.



--
This message was sent by Atlassian JIRA
(v6.1#6144)