[GitHub] erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support

[GitBox <gi...@apache.org>]

erisu commented on a change in pull request #441: CB-14089: (android) Add Kotlin support
URL: https://github.com/apache/cordova-android/pull/441#discussion_r215495327
 
 

 ##########
 File path: bin/templates/project/app/build.gradle
 ##########
 @@ -30,13 +32,14 @@ buildscript {
 
     dependencies {
         classpath 'com.android.tools.build:gradle:3.1.0'
+        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
 
 Review comment:
   Can we wrap all of the Kotlin code and make it conditional by a flag? This is regarding to the same concerns that @dpogue mentioned.
   
   It might be possible that not everyone would use Kotlin.
   
   For example:
   ```
   if (cdvHelpers.getConfigPreference('EnableKotlin', 'false').toBoolean()) {
     classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
   }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org