You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/13 18:12:28 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #5580: Minor: Move RuntimeEnv to `datafusion_execution`
alamb opened a new pull request, #5580:
URL: https://github.com/apache/arrow-datafusion/pull/5580
# Which issue does this PR close?
Part of https://github.com/apache/arrow-datafusion/issues/1754
# Rationale for this change
I am trying to extract the physical_plan code into its own crate; and to do so I need to remove the circular dependencies between core --> datasource --> execution --> datasource
The `RuntimeEnv` is used at runtime, so it belongs in the `datafusion_execution` crate
See more details in https://github.com/apache/arrow-datafusion/issues/1754#issuecomment-1452438453
# What changes are included in this PR?
1. Move RuntimeEnv to `datafusion_execution`
# Are these changes tested?
Covered by existing tests
# Are there any user-facing changes?
No, I added a `pub use` so this code movement should not affect users
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5580: Minor: Move RuntimeEnv to `datafusion_execution`
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5580:
URL: https://github.com/apache/arrow-datafusion/pull/5580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5580: Minor: Move RuntimeEnv to `datafusion_execution`
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5580:
URL: https://github.com/apache/arrow-datafusion/pull/5580#issuecomment-1467946339
Benchmark runs are scheduled for baseline = ce1572f91005d0fd6d2c5510bef2ec1d0cae5537 and contender = 3df1cb37a577d5f584f26670e2d2760dc6eb23d3. 3df1cb37a577d5f584f26670e2d2760dc6eb23d3 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/4e99e789e03d4916a7a19449dc90d827...8cce497e04764f0bbf2aca0401d741d6/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/fb36bf141c414fadbb940e3aae19eecb...131f6f884a6a458bbc033f2e77c80aa7/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1f9410343d3448b4b82293bc57f50878...d6f26990b33b4bb7a6be3b99dd14bb16/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/9417624a3aa4412fbfb6899615c2d3a9...38a6328cb54f412ab617b23ab92eb03e/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org