You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/07/29 07:31:57 UTC

[GitHub] [rocketmq-operator] liuruiyiyang commented on a change in pull request #25: [ISSUE #29] Store the broker configuration and jvm parameters in configmap

liuruiyiyang commented on a change in pull request #25:
URL: https://github.com/apache/rocketmq-operator/pull/25#discussion_r461292041



##########
File path: images/broker/runbroker-customize.sh
##########
@@ -130,7 +130,7 @@ Xmx=$MAX_HEAP_SIZE
 Xmn=$HEAP_NEWSIZE
 MaxDirectMemorySize=$MAX_HEAP_SIZE
 # Set for `JAVA_OPT`.
-JAVA_OPT="${JAVA_OPT} -server -Xms${Xms} -Xmx${Xmx} -Xmn${Xmn}"
+JAVA_OPT="${JAVA_OPT} -server ${BROKER_MEM:-"-Xms${Xms} -Xmx${Xmx} -Xmn${Xmn}"} "

Review comment:
       Could you please describe more about this line? I am not sure how it works. The original script will calculate MEM according to system memory resource. And we are going to add resource limit in future version.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org