You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan Küng <to...@gmail.com> on 2009/04/23 20:08:32 UTC
Update doesn't fetch new files in 1.6.1
Hi,
With an 1.6.1 client, there's a situation where new files aren't fetched
in an update. At least on Windows, can't test on Linux.
Attached a script to reproduce the problem.
This happens when adding a new folder with --depth=empty, which is what
TSVN uses to avoid that files which the user doesn't want to add get
added automatically too. See the comments in the script.
also, the added folder which isn't updated correctly shows that is still
has depth infinity, so that doesn't appear to be the problem.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1881609
Re: Update doesn't fetch new files in 1.6.1
Posted by Stefan Küng <to...@gmail.com>.
Mark Phippard wrote:
> On Thu, Apr 23, 2009 at 4:23 PM, Stefan Küng <to...@gmail.com> wrote:
>> Mark Phippard wrote:
>>> Yes, we've been discussing recently. See:
>>>
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1615432
>>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1861225
>> Ah, haven't seen that. Sorry.
>> But IMHO this is really a bug. Because if you check the working copies
>> after running my test script, there's absolutely *no indication* that
>> the added folder is sparse. The depth still shows up as infinity.
>> I could understand if the depth was set to 'empty' as the add indicates,
>> that would at least give users a clue what's wrong. But the way it works
>> now, everything seems ok but the update still misses files.
>
> I agree completely, and suffer the same problem with Subclipse.
> Perhaps you can review and comment on the patch provided by Mike
> Pilato?
>
Will do, but that has to wait until tomorrow.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1881887
Re: Update doesn't fetch new files in 1.6.1
Posted by Mark Phippard <ma...@gmail.com>.
On Thu, Apr 23, 2009 at 4:23 PM, Stefan Küng <to...@gmail.com> wrote:
> Mark Phippard wrote:
>> Yes, we've been discussing recently. See:
>>
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1615432
>> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1861225
>
> Ah, haven't seen that. Sorry.
> But IMHO this is really a bug. Because if you check the working copies
> after running my test script, there's absolutely *no indication* that
> the added folder is sparse. The depth still shows up as infinity.
> I could understand if the depth was set to 'empty' as the add indicates,
> that would at least give users a clue what's wrong. But the way it works
> now, everything seems ok but the update still misses files.
I agree completely, and suffer the same problem with Subclipse.
Perhaps you can review and comment on the patch provided by Mike
Pilato?
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1881859
Re: Update doesn't fetch new files in 1.6.1
Posted by Stefan Küng <to...@gmail.com>.
Mark Phippard wrote:
> Yes, we've been discussing recently. See:
>
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1615432
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1861225
Ah, haven't seen that. Sorry.
But IMHO this is really a bug. Because if you check the working copies
after running my test script, there's absolutely *no indication* that
the added folder is sparse. The depth still shows up as infinity.
I could understand if the depth was set to 'empty' as the add indicates,
that would at least give users a clue what's wrong. But the way it works
now, everything seems ok but the update still misses files.
Stefan
--
___
oo // \\ "De Chelonian Mobile"
(_,\/ \_/ \ TortoiseSVN
\ \_/_\_/> The coolest Interface to (Sub)Version Control
/_/ \_\ http://tortoisesvn.net
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1881837
Re: Update doesn't fetch new files in 1.6.1
Posted by Mark Phippard <ma...@gmail.com>.
Yes, we've been discussing recently. See:
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1615432
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1861225
On Thu, Apr 23, 2009 at 4:08 PM, Stefan Küng <to...@gmail.com> wrote:
> Hi,
>
> With an 1.6.1 client, there's a situation where new files aren't fetched
> in an update. At least on Windows, can't test on Linux.
>
> Attached a script to reproduce the problem.
>
> This happens when adding a new folder with --depth=empty, which is what
> TSVN uses to avoid that files which the user doesn't want to add get
> added automatically too. See the comments in the script.
>
> also, the added folder which isn't updated correctly shows that is still
> has depth infinity, so that doesn't appear to be the problem.
>
> Stefan
>
> --
> ___
> oo // \\ "De Chelonian Mobile"
> (_,\/ \_/ \ TortoiseSVN
> \ \_/_\_/> The coolest Interface to (Sub)Version Control
> /_/ \_\ http://tortoisesvn.net
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1881609
> ::@echo off
> set ROOT=D:\Development\SVN\SVNTests
> set REPOROOT=D:/Development/SVN/SVNTests
> set REPONAME=adddepthrepo
> set WCNAME=adddepthwc
> set REPO=file:///D:/Development/SVN/SVNTests/adddepthrepo
> set WC=%ROOT%\%WCNAME%
>
> ::set SVNCLI=D:\Development\SVN\TortoiseSVN\bin\debug\bin\svn.exe
> ::set SVNADM=D:\Development\SVN\TortoiseSVN\bin\debug\bin\svnadmin.exe
> set SVNCLI=svn.exe
> set SVNADM=svnadmin.exe
>
> cd %ROOT%
> if exist %REPONAME% rd /s /q %REPONAME%
> if exist %WCNAME% rd /s /q %WCNAME%
> if exist %WCNAME% rd /s /q %WCNAME%2
>
> mkdir %ROOT%\%REPONAME%
> svnadmin create %ROOT%\%REPONAME%
>
> ::echo [general]> %SERVERROOT%\%REPONAME%\conf\svnserve.conf
> ::echo anon-access = write>> %SERVERROOT%\%REPONAME%\conf\svnserve.conf
> rem Launch svnserve for current directory at port 40000
> ::start svnserve.exe --daemon --foreground --root %SERVERROOT%\%REPONAME% --listen-port 40000 --listen-host localhost
>
>
> mkdir %WCNAME%
> cd %WCNAME%
>
> %SVNCLI% import . %REPO% -m "importing project"
> cd ..
> rmdir /s /q %WCNAME%
>
> %SVNCLI% co %REPO% %WC%
> %SVNCLI% co %REPO% %WC%2
>
> :: Creating the folder on WC1
> mkdir %WCNAME%\folder
> echo test > %WCNAME%\folder\file2.txt
> echo test > %WCNAME%\folder\tmp.txt
> :: add folder with empty depth since we only want the folder, not the temp file in it!
> %SVNCLI% add %WCNAME%\folder --depth=empty
> %SVNCLI% add %WCNAME%\folder\file2.txt --depth=empty
> %SVNCLI% ci %WCNAME% -m "adding folder"
>
> :: Update WC2
> %SVNCLI% up %WCNAME%2
>
> :: Create files on WC2, adding and commit
> echo test > %WCNAME%2\folder\file.txt
> echo test > %WCNAME%2\folder\tmp.txt
>
> %SVNCLI% add %WCNAME%2\folder\file.txt --depth=empty
> %SVNCLI% ci %WCNAME%2 -m "adding file"
>
> :: Update WC1
> %SVNCLI% up %WCNAME%
> :: now I'd expect that folder\file.txt is added, but it isn't!
>
>
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=1881756