[GitHub] [avro] sarutak commented on a diff in pull request #2405: AVRO-3818: [Rust] Let inner named types inherit their enclosing namespace if they have no their own namespace

["sarutak (via GitHub)" <gi...@apache.org>]

sarutak commented on code in PR #2405:
URL: https://github.com/apache/avro/pull/2405#discussion_r1279645953


##########
lang/rust/avro/src/schema.rs:
##########
@@ -1518,7 +1528,7 @@ impl Parser {
         }
 
         let schema = Schema::Enum(EnumSchema {
-            name,
+            name: fully_qualified_name.clone(),

Review Comment:
   It's not enough because [this test](https://github.com/apache/avro/pull/2405/files#diff-b702ef60e00210dede234ba524d4ce1d4ff14ef199191ec46a7f4ba8a6bd211eR4944) doesn't pass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org