[GitHub] [streampipes] bossenti commented on a diff in pull request #1142: [#1104] add GitHub workflow to label PRs automatically

["bossenti (via GitHub)" <gi...@apache.org>]

bossenti commented on code in PR #1142:
URL: https://github.com/apache/streampipes/pull/1142#discussion_r1083271649


##########
.github/prlabeller.yml:
##########
@@ -0,0 +1,21 @@
+# Add repo label to any change in any file

Review Comment:
   This is just the example config from the GitHub action, right?
   That does not suit for us, but that's not a problem.
   I will take care of adapting the config accordingly.



##########
config_merge.yml:
##########
@@ -0,0 +1,18 @@
+name: 'PRLabeler'

Review Comment:
   What's the purpose of this file?
   From my understanding, we only need the other two files.



##########
.github/workflows/prlabelling.yaml:
##########
@@ -0,0 +1,16 @@
+name: "Pull Request Labeler"
+run-name: ${{ github.actor }} created Pull Request Labeler
+
+on:
+- pull_request_target

Review Comment:
   If I am not mistaken, this event is only produced when a PR from a forked repository is created. 
   This is not what we desire here. I think the more general `pull_request` event is better suited for us and we should filter on opening events. Read more about that here: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request



##########
.github/workflows/prlabelling.yaml:
##########
@@ -0,0 +1,16 @@
+name: "Pull Request Labeler"
+run-name: ${{ github.actor }} created Pull Request Labeler
+
+on:
+- pull_request_target
+
+jobs:

Review Comment:
   It would be great if you could filter for PRs created by @dependabot
   To do so you can follow this example [here](https://docs.github.com/en/actions/using-workflows/triggering-a-workflow#accessing-and-using-event-properties)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org