You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2018/01/29 05:48:07 UTC

[GitHub] knight9999 opened a new pull request #354: exec purgeProjectFileCache when pod install

knight9999 opened a new pull request #354: exec purgeProjectFileCache when pod install
URL: https://github.com/apache/cordova-ios/pull/354
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   Cordova iOS 4.5.4
   
   ### What does this PR do?
   
   Fix the pod install plugin (plugin with podspec framework) to work.
   
   For example, phonegap-plugin-push plugin with `GoogleService-Info.plist`
   (in config.xml, `<resource-file src="GoogleService-Info.plist" />` is added)
   
   The case, 
   ```
   cordova platform add ios@4.5.4
   cordova plugin add phongegap-plugin-push
   cordova prepare
   cordova compile --device
   ```
    works well.
   The case, 
   ```
   cordova plugin add phonegap-plugin-push
   cordova platform add ios@4.5.4
   cordova prepare
   cordova compile --device
   ```
   does not work becuase the cordova overwrite project.pbxproj which is change by pod install. 
   This pull request fixes this issue.
    
   ### What testing has been done on this change?
   
   Do in my local environment with cordova-ios 4.5.4
   
   ### Checklist
   - [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [ ] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org