You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/07/05 06:36:35 UTC
[GitHub] [doris] Gabriel39 opened a new pull request, #10611: [BUG] fix core dump caused by runtime filter
Gabriel39 opened a new pull request, #10611:
URL: https://github.com/apache/doris/pull/10611
# Proposed changes
Issue Number: close #10610
## Problem Summary:
Describe the overview of changes.
## Checklist(Required)
1. Does it affect the original behavior: (Yes/No/I Don't know)
2. Has unit tests been added: (Yes/No/No Need)
3. Has document been added or modified: (Yes/No/No Need)
4. Does it need to update dependencies: (Yes/No)
5. Are there any changes that cannot be rolled back: (Yes/No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yangzhg commented on a diff in pull request #10611: [BUG] fix core dump caused by runtime filter
Posted by GitBox <gi...@apache.org>.
yangzhg commented on code in PR #10611:
URL: https://github.com/apache/doris/pull/10611#discussion_r914561867
##########
be/src/vec/exec/volap_scan_node.cpp:
##########
@@ -403,7 +403,6 @@ void VOlapScanNode::scanner_thread(VOlapScanner* scanner) {
scanner->set_opened();
}
- /*
// the follow code may cause double free in VExprContext,
Review Comment:
if this bug is fixed those comments should removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei commented on a diff in pull request #10611: [BUG] fix core dump caused by runtime filter
Posted by GitBox <gi...@apache.org>.
yiguolei commented on code in PR #10611:
URL: https://github.com/apache/doris/pull/10611#discussion_r915666333
##########
be/src/vec/exec/volap_scan_node.cpp:
##########
@@ -462,6 +462,9 @@ void VOlapScanNode::scanner_thread(VOlapScanner* scanner) {
vexprs.clear();
break;
}
+ if (_vconjunct_ctx_ptr) {
+ _stale_vexpr_ctxs.push_back(move(_vconjunct_ctx_ptr));
Review Comment:
use std::move
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on a diff in pull request #10611: [BUG] fix core dump caused by runtime filter
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on code in PR #10611:
URL: https://github.com/apache/doris/pull/10611#discussion_r914629927
##########
be/src/vec/exec/volap_scan_node.cpp:
##########
@@ -403,7 +403,6 @@ void VOlapScanNode::scanner_thread(VOlapScanner* scanner) {
scanner->set_opened();
}
- /*
// the follow code may cause double free in VExprContext,
Review Comment:
Done. Thanks for reminding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #10611: [BUG] fix core dump caused by runtime filter
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #10611:
URL: https://github.com/apache/doris/pull/10611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org