[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #8067: net/local:set POLLIN/POLLOUT threshold for local fifo

[GitBox <gi...@apache.org>]

xiaoxiang781216 commented on code in PR #8067:
URL: https://github.com/apache/nuttx/pull/8067#discussion_r1066117503


##########
net/local/local_fifo.c:
##########
@@ -636,6 +701,16 @@ int local_open_sender(FAR struct local_conn_s *conn, FAR const char *path,
       /* Policy: Free FIFO resources when the buffer is empty. */
 
       ret = local_set_policy(&conn->lc_outfile, 1);
+      if (ret == 0)

Review Comment:
   ditto



##########
net/local/local_fifo.c:
##########
@@ -603,6 +657,17 @@ int local_open_receiver(FAR struct local_conn_s *conn, bool nonblock)
       /* Policy: Free FIFO resources when the buffer is empty. */
 
       ret = local_set_policy(&conn->lc_infile, 1);
+
+      if (ret == 0)

Review Comment:
   only nonblock need set threshold?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org