[PR] Introduce commit header 2 [couchdb]

["iilyak (via GitHub)" <gi...@apache.org>]

iilyak opened a new pull request, #5578:
URL: https://github.com/apache/couchdb/pull/5578

   ## Overview
   
   This PR is an optimization to reduce number of messages to `couch_file` process, in cases when we need to call sync. This PR adds `Options`, currently only `sync` option is supported. 
   
   The `couch_file:write_header(Fd, Data, [sync])` is more efficient equivalent of:
   
   ```erlang
   couch_file:sync(Fd),
   ok = couch_file:write_header(Fd, NewHeader),
   couch_file:sync(Fd),
   ```
   
   ## Testing recommendations
   
   ```shell
   make eunit apps=couch tests=write_header_sync_test_
   ```
   
   ## Related Issues or Pull Requests
   
   This a replacement PR for #5577 and #5576.
   
   ## Checklist
   
   - [x] Code is written and works correctly
   - [x] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] Documentation changes were made in the `src/docs` folder
   - [ ] Documentation changes were backported (separated PR) to affected branches
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Introduce sync option for couch_file:write_header [couchdb]

["iilyak (via GitHub)" <gi...@apache.org>]

iilyak merged PR #5578:
URL: https://github.com/apache/couchdb/pull/5578


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org