You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@systemml.apache.org by mb...@apache.org on 2016/06/25 06:09:04 UTC

[1/2] incubator-systemml git commit: [SYSTEMML-556] Simplified json meta data string construction, for apis

Repository: incubator-systemml
Updated Branches:
  refs/heads/master 3a3c16599 -> 34a2e1d8a


[SYSTEMML-556] Simplified json meta data string construction, for apis

Project: http://git-wip-us.apache.org/repos/asf/incubator-systemml/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-systemml/commit/8c4f83a1
Tree: http://git-wip-us.apache.org/repos/asf/incubator-systemml/tree/8c4f83a1
Diff: http://git-wip-us.apache.org/repos/asf/incubator-systemml/diff/8c4f83a1

Branch: refs/heads/master
Commit: 8c4f83a15491c8c5afa539102de188ac1fa5c25d
Parents: 3a3c165
Author: Matthias Boehm <mb...@us.ibm.com>
Authored: Fri Jun 24 20:19:22 2016 -0700
Committer: Matthias Boehm <mb...@us.ibm.com>
Committed: Fri Jun 24 20:37:26 2016 -0700

----------------------------------------------------------------------
 .../sysml/runtime/matrix/data/OutputInfo.java   |  22 +++
 .../sysml/runtime/util/MapReduceTool.java       | 191 ++++++++-----------
 2 files changed, 98 insertions(+), 115 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/8c4f83a1/src/main/java/org/apache/sysml/runtime/matrix/data/OutputInfo.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/matrix/data/OutputInfo.java b/src/main/java/org/apache/sysml/runtime/matrix/data/OutputInfo.java
index 4d4a975..3efbee3 100644
--- a/src/main/java/org/apache/sysml/runtime/matrix/data/OutputInfo.java
+++ b/src/main/java/org/apache/sysml/runtime/matrix/data/OutputInfo.java
@@ -31,6 +31,7 @@ import org.apache.hadoop.io.Writable;
 import org.apache.hadoop.mapred.OutputFormat;
 import org.apache.hadoop.mapred.SequenceFileOutputFormat;
 import org.apache.hadoop.mapred.TextOutputFormat;
+import org.apache.sysml.parser.DataExpression;
 import org.apache.sysml.runtime.DMLRuntimeException;
 import org.apache.sysml.runtime.matrix.mapred.CSVWriteReducer.RowBlockForTextOutput;
 import org.apache.sysml.runtime.matrix.sort.CompactOutputFormat;
@@ -140,6 +141,27 @@ public class OutputInfo implements Serializable
 			throw new DMLRuntimeException("Unrecognized outputInfo: " + oi);
 	}
 	
+	/**
+	 * 
+	 * @param oinfo
+	 * @return
+	 * @throws DMLRuntimeException 
+	 */
+	public static String outputInfoToStringExternal(OutputInfo oinfo) 
+		throws DMLRuntimeException 
+	{
+		if( oinfo == OutputInfo.TextCellOutputInfo )
+			return DataExpression.FORMAT_TYPE_VALUE_TEXT;
+		else if( oinfo == OutputInfo.MatrixMarketOutputInfo )
+			return DataExpression.FORMAT_TYPE_VALUE_MATRIXMARKET;
+		else if( oinfo == OutputInfo.CSVOutputInfo )
+			return DataExpression.FORMAT_TYPE_VALUE_CSV;
+		else if( oinfo == OutputInfo.BinaryBlockOutputInfo )
+			return DataExpression.FORMAT_TYPE_VALUE_BINARY;
+		else
+			throw new DMLRuntimeException("Unrecognized outputInfo: " + oinfo);
+	}
+	
 	@Override
 	public boolean equals( Object o ) 
 	{

http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/8c4f83a1/src/main/java/org/apache/sysml/runtime/util/MapReduceTool.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/util/MapReduceTool.java b/src/main/java/org/apache/sysml/runtime/util/MapReduceTool.java
index 1a11af9..77d5bd6 100644
--- a/src/main/java/org/apache/sysml/runtime/util/MapReduceTool.java
+++ b/src/main/java/org/apache/sysml/runtime/util/MapReduceTool.java
@@ -55,6 +55,7 @@ import org.apache.sysml.runtime.matrix.data.NumItemsByEachReducerMetaData;
 import org.apache.sysml.runtime.matrix.data.OutputInfo;
 import org.apache.sysml.runtime.matrix.mapred.MRConfigurationNames;
 import org.apache.sysml.runtime.matrix.sort.ReadWithZeros;
+import org.apache.wink.json4j.JSONException;
 import org.apache.wink.json4j.OrderedJSONObject;
 
 
@@ -395,7 +396,6 @@ public class MapReduceTool
         }
         br.write(line.toString());
         br.close();
-        //System.out.println("Finished writing dimsFile: " + filename);
 	}
 	
 	public static MatrixCharacteristics[] processDimsFiles(String dir, MatrixCharacteristics[] stats) 
@@ -461,136 +461,97 @@ public class MapReduceTool
 		Path pt = new Path(mtdfile);
 		FileSystem fs = FileSystem.get(_rJob);
 		BufferedWriter br = new BufferedWriter(new OutputStreamWriter(fs.create(pt,true)));
-		formatProperties = (formatProperties==null && outinfo==OutputInfo.CSVOutputInfo) ?
-				new CSVFileFormatProperties() : formatProperties;
-		OrderedJSONObject mtd = new OrderedJSONObject(); // maintain order in output file
 
 		try {
-			// build JSON metadata object
-			mtd.put(DataExpression.DATATYPEPARAM, dt.toString().toLowerCase());
-			if (schema == null)
-				switch (vt) {
-					case DOUBLE:
-						mtd.put(DataExpression.VALUETYPEPARAM, "double");
-						break;
-					case INT:
-						mtd.put(DataExpression.VALUETYPEPARAM, "int");
-						break;
-					case BOOLEAN:
-						mtd.put(DataExpression.VALUETYPEPARAM, "boolean");
-						break;
-					case STRING:
-						mtd.put(DataExpression.VALUETYPEPARAM, "string");
-						break;
-					case UNKNOWN:
-						mtd.put(DataExpression.VALUETYPEPARAM, "unknown");
-						break;
-					case OBJECT:
-						mtd.put(DataExpression.VALUETYPEPARAM, "object");
-						break;
-				}
-			else
-			{
-				StringBuffer schemaStrBuffer = new StringBuffer();
-				for(int i=0; i < schema.size(); i++) {
-					switch (schema.get(i)) {
-						case DOUBLE:
-							schemaStrBuffer.append("DOUBLE");
-							break;
-						case INT:
-							schemaStrBuffer.append("INT");
-							break;
-						case BOOLEAN:
-							schemaStrBuffer.append("BOOLEAN");
-							break;
-						case STRING:
-							schemaStrBuffer.append("STRING");
-							break;
-						case UNKNOWN:
-						default:
-							schemaStrBuffer.append("*");
-							break;
-					}
-					schemaStrBuffer.append(DataExpression.DEFAULT_DELIM_DELIMITER);
-				}
-				mtd.put(DataExpression.SCHEMAPARAM, schemaStrBuffer.toString());
-			}
-			mtd.put(DataExpression.READROWPARAM, mc.getRows());
-			mtd.put(DataExpression.READCOLPARAM, mc.getCols());
-			// only output rows_in_block and cols_in_block for matrix binary format
-			if (outinfo == OutputInfo.BinaryBlockOutputInfo && dt.isMatrix() ) {
-				mtd.put(DataExpression.ROWBLOCKCOUNTPARAM, mc.getRowsPerBlock());
-				mtd.put(DataExpression.COLUMNBLOCKCOUNTPARAM, mc.getColsPerBlock());
-			}
-			// only output nnz for matrix
-			if( dt.isMatrix() ) {
-				mtd.put(DataExpression.READNUMNONZEROPARAM, mc.getNonZeros());
-			}
-			if (outinfo == OutputInfo.TextCellOutputInfo) {
-				mtd.put(DataExpression.FORMAT_TYPE, "text");
-			} else if (outinfo == OutputInfo.BinaryBlockOutputInfo || outinfo == OutputInfo.BinaryCellOutputInfo ) {
-				mtd.put(DataExpression.FORMAT_TYPE, "binary");
-			} else if (outinfo == OutputInfo.CSVOutputInfo) {
-				mtd.put(DataExpression.FORMAT_TYPE, "csv");
-			} else {
-				mtd.put(DataExpression.FORMAT_TYPE, "specialized");
-			}
-			if (outinfo == OutputInfo.CSVOutputInfo) {
-				CSVFileFormatProperties csvProperties = (CSVFileFormatProperties) formatProperties;
-				mtd.put(DataExpression.DELIM_HAS_HEADER_ROW, csvProperties.hasHeader());
-				mtd.put(DataExpression.DELIM_DELIMITER, csvProperties.getDelim());
-			}
-			mtd.put(DataExpression.DESCRIPTIONPARAM,
-					new OrderedJSONObject().put(DataExpression.AUTHORPARAM, "SystemML"));
-
-			// write metadata JSON object to file
-			mtd.write(br, 4); // indent with 4 spaces
+			String mtd = metaDataToString(mtdfile, vt, schema, dt, mc, outinfo, formatProperties);
+			br.write(mtd);
 			br.close();
 		} catch (Exception e) {
 			throw new IOException("Error creating and writing metadata JSON file", e);
 		}
 	}
 
-	public static void writeScalarMetaDataFile(String mtdfile, ValueType v) throws IOException {
-		Path pt=new Path(mtdfile);
+	public static void writeScalarMetaDataFile(String mtdfile, ValueType vt) 
+		throws IOException 
+	{
+		Path pt = new Path(mtdfile);
 		FileSystem fs = FileSystem.get(_rJob);
-		BufferedWriter br=new BufferedWriter(new OutputStreamWriter(fs.create(pt,true)));
-		OrderedJSONObject mtd = new OrderedJSONObject(); // maintain order in output file
+		BufferedWriter br = new BufferedWriter(new OutputStreamWriter(fs.create(pt,true)));
 
 		try {
-			// build JSON metadata object
-			mtd.put(DataExpression.DATATYPEPARAM, "scalar");
-			switch (v) {
-				case DOUBLE:
-					mtd.put(DataExpression.VALUETYPEPARAM, "double");
-					break;
-				case INT:
-					mtd.put(DataExpression.VALUETYPEPARAM, "int");
-					break;
-				case BOOLEAN:
-					mtd.put(DataExpression.VALUETYPEPARAM, "boolean");
-					break;
-				case STRING:
-					mtd.put(DataExpression.VALUETYPEPARAM, "string");
-					break;
-				case UNKNOWN:
-					mtd.put(DataExpression.VALUETYPEPARAM, "unknown");
-					break;
-				case OBJECT:
-					throw new IOException("Write of generic object types not supported.");
-			}
-			mtd.put(DataExpression.FORMAT_TYPE, "text");
-			mtd.put(DataExpression.DESCRIPTIONPARAM,
-					new OrderedJSONObject().put(DataExpression.AUTHORPARAM, "SystemML"));
-
-			// write metadata JSON object to file
-			mtd.write(br, 4); // indent with 4 spaces
+			String mtd = metaDataToString(mtdfile, vt, null, 
+				DataType.SCALAR, null, OutputInfo.TextCellOutputInfo, null);
+			br.write(mtd);
 			br.close();
-		} catch (Exception e) {
+		} 
+		catch (Exception e) {
 			throw new IOException("Error creating and writing metadata JSON file", e);
 		}
 	}
 	
+	/**
+	 * 
+	 * @param mtdfile
+	 * @param vt
+	 * @param schema
+	 * @param dt
+	 * @param mc
+	 * @param outinfo
+	 * @param formatProperties
+	 * @return
+	 * @throws JSONException 
+	 * @throws DMLRuntimeException 
+	 */
+	public static String metaDataToString(String mtdfile, ValueType vt, List<ValueType> schema, DataType dt, MatrixCharacteristics mc, 
+			OutputInfo outinfo, FileFormatProperties formatProperties) throws JSONException, DMLRuntimeException
+	{
+		OrderedJSONObject mtd = new OrderedJSONObject(); // maintain order in output file
+
+		//handle data type and value types (incl schema for frames)
+		mtd.put(DataExpression.DATATYPEPARAM, dt.toString().toLowerCase());
+		if (schema == null) {
+			mtd.put(DataExpression.VALUETYPEPARAM, vt.toString().toLowerCase());
+		}	
+		else {
+			StringBuffer schemaSB = new StringBuffer();
+			for(int i=0; i < schema.size(); i++) {
+				if( schema.get(i) == ValueType.UNKNOWN )
+					schemaSB.append("*");
+				else
+					schemaSB.append(schema.get(i).toString());
+				schemaSB.append(DataExpression.DEFAULT_DELIM_DELIMITER);
+			}
+			mtd.put(DataExpression.SCHEMAPARAM, schemaSB.toString());
+		}
+		
+		//handle output dimensions
+		if( !dt.isScalar() ) {
+			mtd.put(DataExpression.READROWPARAM, mc.getRows());
+			mtd.put(DataExpression.READCOLPARAM, mc.getCols());
+			// handle output nnz and binary block configuration
+			if( dt.isMatrix() ) {
+				if (outinfo == OutputInfo.BinaryBlockOutputInfo ) {
+					mtd.put(DataExpression.ROWBLOCKCOUNTPARAM, mc.getRowsPerBlock());
+					mtd.put(DataExpression.COLUMNBLOCKCOUNTPARAM, mc.getColsPerBlock());
+				}
+				mtd.put(DataExpression.READNUMNONZEROPARAM, mc.getNonZeros());
+			}
+		}
+			
+		//handle format type and additional arguments	
+		mtd.put(DataExpression.FORMAT_TYPE, OutputInfo.outputInfoToStringExternal(outinfo));
+		if (outinfo == OutputInfo.CSVOutputInfo) {
+			CSVFileFormatProperties csvProperties = (formatProperties==null) ?
+				new CSVFileFormatProperties() : (CSVFileFormatProperties)formatProperties;
+			mtd.put(DataExpression.DELIM_HAS_HEADER_ROW, csvProperties.hasHeader());
+			mtd.put(DataExpression.DELIM_DELIMITER, csvProperties.getDelim());
+		}
+		mtd.put(DataExpression.DESCRIPTIONPARAM,
+			new OrderedJSONObject().put(DataExpression.AUTHORPARAM, "SystemML"));
+
+		return mtd.toString(4); // indent with 4 spaces	
+	}
+	
 	public static double[][] readMatrixFromHDFS(String dir, InputInfo inputinfo, long rlen, long clen, int brlen, int bclen) 
 		throws IOException, DMLRuntimeException
 	{


[2/2] incubator-systemml git commit: [SYSTEMML-630] Fix robustness csv frame readers (count num columns)

Posted by mb...@apache.org.
[SYSTEMML-630] Fix robustness csv frame readers (count num columns)

In corner cases, our distributed csv write produces empty partitions and
hence empty csv file splits. Depending on the ordering of splits, this
causes problems when determining the number of columns on csv read with
a single row only. This patch introduces a more robust approach for
computing the number of columns on csv read, where we read split headers
until we find a row with ncol>0.  

Project: http://git-wip-us.apache.org/repos/asf/incubator-systemml/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-systemml/commit/34a2e1d8
Tree: http://git-wip-us.apache.org/repos/asf/incubator-systemml/tree/34a2e1d8
Diff: http://git-wip-us.apache.org/repos/asf/incubator-systemml/diff/34a2e1d8

Branch: refs/heads/master
Commit: 34a2e1d8a6f7c7247dd8f8e505b4c2054f4b2589
Parents: 8c4f83a
Author: Matthias Boehm <mb...@us.ibm.com>
Authored: Fri Jun 24 23:08:52 2016 -0700
Committer: Matthias Boehm <mb...@us.ibm.com>
Committed: Fri Jun 24 23:08:52 2016 -0700

----------------------------------------------------------------------
 .../sysml/runtime/io/FrameReaderTextCSV.java    | 21 ++++------
 .../runtime/io/FrameReaderTextCSVParallel.java  | 16 ++------
 .../sysml/runtime/io/IOUtilFunctions.java       | 40 ++++++++++++++++++++
 .../TransformFrameEncodeDecodeTest.java         |  2 -
 4 files changed, 52 insertions(+), 27 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/34a2e1d8/src/main/java/org/apache/sysml/runtime/io/FrameReaderTextCSV.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/io/FrameReaderTextCSV.java b/src/main/java/org/apache/sysml/runtime/io/FrameReaderTextCSV.java
index 05796fd..b5a5756 100644
--- a/src/main/java/org/apache/sysml/runtime/io/FrameReaderTextCSV.java
+++ b/src/main/java/org/apache/sysml/runtime/io/FrameReaderTextCSV.java
@@ -23,7 +23,6 @@ import java.io.IOException;
 import java.util.Arrays;
 import java.util.List;
 
-import org.apache.commons.lang.StringUtils;
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.Path;
 import org.apache.hadoop.io.LongWritable;
@@ -217,26 +216,22 @@ public class FrameReaderTextCSV extends FrameReader
 		InputSplit[] splits = informat.getSplits(job, 1);
 		splits = IOUtilFunctions.sortInputSplits(splits);
 		
-		boolean first = true;
-		int ncol = -1;
-		int nrow = -1;
+		//compute number of columns
+		int ncol = IOUtilFunctions.countNumColumnsCSV(splits, informat, job, _props.getDelim());
 		
-		for( InputSplit split : splits ) 
+		//compute number of rows
+		int nrow = -1;
+		for( int i=0; i<splits.length; i++ ) 
 		{
-			RecordReader<LongWritable, Text> reader = informat.getRecordReader(split, job, Reporter.NULL);
+			RecordReader<LongWritable, Text> reader = informat.getRecordReader(splits[i], job, Reporter.NULL);
 			LongWritable key = new LongWritable();
 			Text value = new Text();
 			
 			try
 			{
-				//read head and first line to determine num columns
-				if( first ) {
-					if ( _props.hasHeader() ) 
-						reader.next(key, value); //ignore header
+				//ignore header of first split
+				if( i==0 && _props.hasHeader() )
 					reader.next(key, value);
-					ncol = StringUtils.countMatches(value.toString(), _props.getDelim()) + 1;
-					nrow = 1; first = false;
-				}
 				
 				//count remaining number of rows
 				while ( reader.next(key, value) )

http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/34a2e1d8/src/main/java/org/apache/sysml/runtime/io/FrameReaderTextCSVParallel.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/io/FrameReaderTextCSVParallel.java b/src/main/java/org/apache/sysml/runtime/io/FrameReaderTextCSVParallel.java
index cb7a05b..da71905 100644
--- a/src/main/java/org/apache/sysml/runtime/io/FrameReaderTextCSVParallel.java
+++ b/src/main/java/org/apache/sysml/runtime/io/FrameReaderTextCSVParallel.java
@@ -27,7 +27,6 @@ import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 import java.util.concurrent.Future;
 
-import org.apache.commons.lang.StringUtils;
 import org.apache.hadoop.fs.FileSystem;
 import org.apache.hadoop.fs.Path;
 import org.apache.hadoop.io.LongWritable;
@@ -96,7 +95,7 @@ public class FrameReaderTextCSVParallel extends FrameReaderTextCSV
 				offset += count.get();
 			}
 			
-			//read individial splits
+			//read individual splits
 			ArrayList<ReadRowsTask> tasks2 = new ArrayList<ReadRowsTask>();
 			for( int i=0; i<splits.length; i++ )
 				tasks2.add( new ReadRowsTask(splits[i], informat, job, dest, offsets.get(i).intValue(), i==0));
@@ -115,7 +114,7 @@ public class FrameReaderTextCSVParallel extends FrameReaderTextCSV
 	@Override
 	protected Pair<Integer,Integer> computeCSVSize( Path path, JobConf job, FileSystem fs) 
 		throws IOException 
-	{		
+	{	
 		int numThreads = OptimizerUtils.getParallelTextReadParallelism();
 		
 		TextInputFormat informat = new TextInputFormat();
@@ -123,18 +122,11 @@ public class FrameReaderTextCSVParallel extends FrameReaderTextCSV
 		InputSplit[] splits = informat.getSplits(job, numThreads);
 		
 		//compute number of columns
-		RecordReader<LongWritable, Text> reader = informat.getRecordReader(splits[0], job, Reporter.NULL);
-		LongWritable key = new LongWritable();
-		Text value = new Text();
-		reader.next(key, value);
-		int ncol = StringUtils.countMatches(value.toString(), _props.getDelim()) + 1;
-		reader.close();
+		int ncol = IOUtilFunctions.countNumColumnsCSV(splits, informat, job, _props.getDelim());
 		
 		//compute number of rows
-		ExecutorService pool = Executors.newFixedThreadPool(numThreads);
-		
-		//compute num rows per split
 		int nrow = 0;
+		ExecutorService pool = Executors.newFixedThreadPool(numThreads);
 		try {
 			ArrayList<CountRowsTask> tasks = new ArrayList<CountRowsTask>();
 			for( int i=0; i<splits.length; i++ )

http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/34a2e1d8/src/main/java/org/apache/sysml/runtime/io/IOUtilFunctions.java
----------------------------------------------------------------------
diff --git a/src/main/java/org/apache/sysml/runtime/io/IOUtilFunctions.java b/src/main/java/org/apache/sysml/runtime/io/IOUtilFunctions.java
index 48787b1..1b80f90 100644
--- a/src/main/java/org/apache/sysml/runtime/io/IOUtilFunctions.java
+++ b/src/main/java/org/apache/sysml/runtime/io/IOUtilFunctions.java
@@ -31,9 +31,14 @@ import org.apache.commons.lang.StringUtils;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.io.LongWritable;
+import org.apache.hadoop.io.Text;
 import org.apache.hadoop.mapred.FileSplit;
+import org.apache.hadoop.mapred.InputFormat;
 import org.apache.hadoop.mapred.InputSplit;
+import org.apache.hadoop.mapred.JobConf;
 import org.apache.hadoop.mapred.RecordReader;
+import org.apache.hadoop.mapred.Reporter;
 import org.apache.sysml.runtime.util.LocalFileUtils;
 import org.apache.sysml.runtime.util.UtilFunctions;
 
@@ -182,4 +187,39 @@ public class IOUtilFunctions
 		}		
 		return splits;
 	}
+	
+	/**
+	 * Counts the number of columns in a given collection of csv file splits. This primitive aborts 
+	 * if a row with more than 0 columns is found and hence is robust against empty file splits etc.
+	 * 
+	 * @param splits
+	 * @param informat
+	 * @param job
+	 * @param delim
+	 * @return
+	 * @throws IOException 
+	 */
+	@SuppressWarnings({ "rawtypes", "unchecked" })
+	public static int countNumColumnsCSV(InputSplit[] splits, InputFormat informat, JobConf job, String delim ) 
+		throws IOException 
+	{
+		LongWritable key = new LongWritable();
+		Text value = new Text();
+		int ncol = -1;
+		for( int i=0; i<splits.length && ncol<=0; i++ ) {
+			RecordReader<LongWritable, Text> reader = 
+					informat.getRecordReader(splits[i], job, Reporter.NULL);
+			try {
+				if( reader.next(key, value) ) {
+					String row = value.toString().trim();
+					if( !row.isEmpty() )
+						ncol = StringUtils.countMatches(row, delim) + 1;
+				}
+			}
+			finally {
+				closeSilently(reader);	
+			}
+		}
+		return ncol;
+	}
 }

http://git-wip-us.apache.org/repos/asf/incubator-systemml/blob/34a2e1d8/src/test/java/org/apache/sysml/test/integration/functions/transform/TransformFrameEncodeDecodeTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/sysml/test/integration/functions/transform/TransformFrameEncodeDecodeTest.java b/src/test/java/org/apache/sysml/test/integration/functions/transform/TransformFrameEncodeDecodeTest.java
index 946bb3d..09f497e 100644
--- a/src/test/java/org/apache/sysml/test/integration/functions/transform/TransformFrameEncodeDecodeTest.java
+++ b/src/test/java/org/apache/sysml/test/integration/functions/transform/TransformFrameEncodeDecodeTest.java
@@ -122,8 +122,6 @@ public class TransformFrameEncodeDecodeTest extends AutomatedTestBase
 			OptimizerUtils.ALLOW_FRAME_CSV_REBLOCK = true;
 			runTest(true, false, null, -1); 
 			
-			//System.exit(1);
-			
 			//read input/output and compare
 			FrameReader reader1 = FrameReaderFactory.createFrameReader(InputInfo.CSVInputInfo, 
 					new CSVFileFormatProperties(true, ",", false));