You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/03/23 20:25:22 UTC
[GitHub] [incubator-mxnet] waytrue17 opened a new pull request #20084: [v1.x] Fix cu100 pip link
waytrue17 opened a new pull request #20084:
URL: https://github.com/apache/incubator-mxnet/pull/20084
## Description ##
Fix cu100 pip link
## Checklist ##
### Essentials ###
- [ ] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
- [ ] Changes are complete (i.e. I finished coding on this PR)
- [ ] All changes have test coverage
- [ ] Code is well-documented
### Changes ###
- [ ] Feature1, tests, (and when applicable, API doc)
- [ ] Feature2, tests, (and when applicable, API doc)
## Comments ##
- If this change is a backward incompatible change, why must this change be made.
- Interesting edge cases to note here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] waytrue17 commented on a change in pull request #20084: [v1.x] Fix cu100 pip link
Posted by GitBox <gi...@apache.org>.
waytrue17 commented on a change in pull request #20084:
URL: https://github.com/apache/incubator-mxnet/pull/20084#discussion_r599953502
##########
File path: tools/pip/doc/CU101_ADDITIONAL.md
##########
@@ -21,7 +21,7 @@ This package supports Linux and Windows platforms. You may also want to check:
- [mxnet-cu112](https://pypi.python.org/pypi/mxnet-cu112/) with CUDA-11.2 support.
Review comment:
Added new lines in all variant files. Thanks for the suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #20084: [v1.x] Fix cu100 pip link
Posted by GitBox <gi...@apache.org>.
samskalicky commented on a change in pull request #20084:
URL: https://github.com/apache/incubator-mxnet/pull/20084#discussion_r599949460
##########
File path: tools/pip/doc/CU101_ADDITIONAL.md
##########
@@ -21,7 +21,7 @@ This package supports Linux and Windows platforms. You may also want to check:
- [mxnet-cu112](https://pypi.python.org/pypi/mxnet-cu112/) with CUDA-11.2 support.
- [mxnet-cu110](https://pypi.python.org/pypi/mxnet-cu110/) with CUDA-11.0 support.
- [mxnet-cu102](https://pypi.python.org/pypi/mxnet-cu102/) with CUDA-10.2 support.
-- [mxnet-cu100](https://pypi.python.org/pypi/mxnet-cu101/) with CUDA-10.0 support.
Review comment:
got it, makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #20084: [v1.x] Fix cu100 pip link
Posted by GitBox <gi...@apache.org>.
samskalicky commented on a change in pull request #20084:
URL: https://github.com/apache/incubator-mxnet/pull/20084#discussion_r599948141
##########
File path: tools/pip/doc/CU101_ADDITIONAL.md
##########
@@ -21,7 +21,7 @@ This package supports Linux and Windows platforms. You may also want to check:
- [mxnet-cu112](https://pypi.python.org/pypi/mxnet-cu112/) with CUDA-11.2 support.
Review comment:
can we add a newline here between the text and the list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #20084: [v1.x] Fix cu100 pip link
Posted by GitBox <gi...@apache.org>.
samskalicky commented on a change in pull request #20084:
URL: https://github.com/apache/incubator-mxnet/pull/20084#discussion_r599929681
##########
File path: tools/pip/doc/CU101_ADDITIONAL.md
##########
@@ -21,7 +21,7 @@ This package supports Linux and Windows platforms. You may also want to check:
- [mxnet-cu112](https://pypi.python.org/pypi/mxnet-cu112/) with CUDA-11.2 support.
- [mxnet-cu110](https://pypi.python.org/pypi/mxnet-cu110/) with CUDA-11.0 support.
- [mxnet-cu102](https://pypi.python.org/pypi/mxnet-cu102/) with CUDA-10.2 support.
-- [mxnet-cu100](https://pypi.python.org/pypi/mxnet-cu101/) with CUDA-10.0 support.
Review comment:
do we want to list the mxnet-cu101 variant too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky merged pull request #20084: [v1.x] Fix cu100 pip link
Posted by GitBox <gi...@apache.org>.
samskalicky merged pull request #20084:
URL: https://github.com/apache/incubator-mxnet/pull/20084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20084: [v1.x] Fix cu100 pip link
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20084:
URL: https://github.com/apache/incubator-mxnet/pull/20084#issuecomment-805224176
Hey @waytrue17 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [centos-gpu, centos-cpu, website, sanity, miscellaneous, edge, unix-cpu, unix-gpu, clang, windows-gpu, windows-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] samskalicky commented on a change in pull request #20084: [v1.x] Fix cu100 pip link
Posted by GitBox <gi...@apache.org>.
samskalicky commented on a change in pull request #20084:
URL: https://github.com/apache/incubator-mxnet/pull/20084#discussion_r599929681
##########
File path: tools/pip/doc/CU101_ADDITIONAL.md
##########
@@ -21,7 +21,7 @@ This package supports Linux and Windows platforms. You may also want to check:
- [mxnet-cu112](https://pypi.python.org/pypi/mxnet-cu112/) with CUDA-11.2 support.
- [mxnet-cu110](https://pypi.python.org/pypi/mxnet-cu110/) with CUDA-11.0 support.
- [mxnet-cu102](https://pypi.python.org/pypi/mxnet-cu102/) with CUDA-10.2 support.
-- [mxnet-cu100](https://pypi.python.org/pypi/mxnet-cu101/) with CUDA-10.0 support.
Review comment:
do we want to list the mxnet-cu101 variant too? we are publishing it on PyPI: https://pypi.org/project/mxnet-cu101/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] waytrue17 commented on a change in pull request #20084: [v1.x] Fix cu100 pip link
Posted by GitBox <gi...@apache.org>.
waytrue17 commented on a change in pull request #20084:
URL: https://github.com/apache/incubator-mxnet/pull/20084#discussion_r599948005
##########
File path: tools/pip/doc/CU101_ADDITIONAL.md
##########
@@ -21,7 +21,7 @@ This package supports Linux and Windows platforms. You may also want to check:
- [mxnet-cu112](https://pypi.python.org/pypi/mxnet-cu112/) with CUDA-11.2 support.
- [mxnet-cu110](https://pypi.python.org/pypi/mxnet-cu110/) with CUDA-11.0 support.
- [mxnet-cu102](https://pypi.python.org/pypi/mxnet-cu102/) with CUDA-10.2 support.
-- [mxnet-cu100](https://pypi.python.org/pypi/mxnet-cu101/) with CUDA-10.0 support.
Review comment:
Seems this part is a reference to other variants not including itself. Other files like `tools/pip/doc/CU100_ADDITIONAL.md` and `tools/pip/doc/CU102_ADDITIONAL.md` do not include the self link either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org