You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrew Zhang (JIRA)" <ji...@apache.org> on 2006/06/27 12:41:29 UTC
[jira] Created: (HARMONY-675) [classlib][nio] Refactor
ServerSocketAdapter.accept(Socket, SocketChannelImpl) in
o.a.h.nio.internal.ServerSocketChannelImpl
[classlib][nio] Refactor ServerSocketAdapter.accept(Socket, SocketChannelImpl) in o.a.h.nio.internal.ServerSocketChannelImpl
------------------------------------------------------------------------------------------------------------------------------
Key: HARMONY-675
URL: http://issues.apache.org/jira/browse/HARMONY-675
Project: Harmony
Type: Bug
Components: Classlib
Reporter: Andrew Zhang
Priority: Minor
There are serveral problems in ServerSocketAdapter.accept(Socket, SocketChannelImpl) method:
1. The modifier should be private, not public. As spec says: "The returned object will not declare any public methods that are not declared in the ServerSocket class."
2. One unnecessary FIXME.
3. Some unneccessray code.
I'll upload a patch soon. Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-675) [classlib][nio] Refactor
ServerSocketAdapter.accept(Socket, SocketChannelImpl) in
o.a.h.nio.internal.ServerSocketChannelImpl
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-675?page=all ]
George Harley resolved HARMONY-675:
-----------------------------------
Resolution: Fixed
Hi Andrew,
Patch committed in revision 417579. Please could you check that it has been applied as expected.
Best regards,
George
> [classlib][nio] Refactor ServerSocketAdapter.accept(Socket, SocketChannelImpl) in o.a.h.nio.internal.ServerSocketChannelImpl
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-675
> URL: http://issues.apache.org/jira/browse/HARMONY-675
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: nio.diff
>
> There are serveral problems in ServerSocketAdapter.accept(Socket, SocketChannelImpl) method:
> 1. The modifier should be private, not public. As spec says: "The returned object will not declare any public methods that are not declared in the ServerSocket class."
> 2. One unnecessary FIXME.
> 3. Some unneccessray code.
> I'll upload a patch soon. Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-675) [classlib][nio] Refactor
ServerSocketAdapter.accept(Socket, SocketChannelImpl) in
o.a.h.nio.internal.ServerSocketChannelImpl
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-675?page=all ]
George Harley reassigned HARMONY-675:
-------------------------------------
Assign To: George Harley
> [classlib][nio] Refactor ServerSocketAdapter.accept(Socket, SocketChannelImpl) in o.a.h.nio.internal.ServerSocketChannelImpl
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-675
> URL: http://issues.apache.org/jira/browse/HARMONY-675
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: nio.diff
>
> There are serveral problems in ServerSocketAdapter.accept(Socket, SocketChannelImpl) method:
> 1. The modifier should be private, not public. As spec says: "The returned object will not declare any public methods that are not declared in the ServerSocket class."
> 2. One unnecessary FIXME.
> 3. Some unneccessray code.
> I'll upload a patch soon. Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-675) [classlib][nio] Refactor
ServerSocketAdapter.accept(Socket, SocketChannelImpl) in
o.a.h.nio.internal.ServerSocketChannelImpl
Posted by "George Harley (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-675?page=all ]
George Harley closed HARMONY-675:
---------------------------------
Verified by Andrew.
> [classlib][nio] Refactor ServerSocketAdapter.accept(Socket, SocketChannelImpl) in o.a.h.nio.internal.ServerSocketChannelImpl
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-675
> URL: http://issues.apache.org/jira/browse/HARMONY-675
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: nio.diff
>
> There are serveral problems in ServerSocketAdapter.accept(Socket, SocketChannelImpl) method:
> 1. The modifier should be private, not public. As spec says: "The returned object will not declare any public methods that are not declared in the ServerSocket class."
> 2. One unnecessary FIXME.
> 3. Some unneccessray code.
> I'll upload a patch soon. Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-675) [classlib][nio] Refactor
ServerSocketAdapter.accept(Socket, SocketChannelImpl) in
o.a.h.nio.internal.ServerSocketChannelImpl
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-675?page=all ]
Andrew Zhang updated HARMONY-675:
---------------------------------
Attachment: nio.diff
Hello,
Would you please try my patch?
Thanks!
Best regards,
Andrew
> [classlib][nio] Refactor ServerSocketAdapter.accept(Socket, SocketChannelImpl) in o.a.h.nio.internal.ServerSocketChannelImpl
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-675
> URL: http://issues.apache.org/jira/browse/HARMONY-675
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Priority: Minor
> Attachments: nio.diff
>
> There are serveral problems in ServerSocketAdapter.accept(Socket, SocketChannelImpl) method:
> 1. The modifier should be private, not public. As spec says: "The returned object will not declare any public methods that are not declared in the ServerSocket class."
> 2. One unnecessary FIXME.
> 3. Some unneccessray code.
> I'll upload a patch soon. Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-675) [classlib][nio] Refactor
ServerSocketAdapter.accept(Socket, SocketChannelImpl) in
o.a.h.nio.internal.ServerSocketChannelImpl
Posted by "Andrew Zhang (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-675?page=comments#action_12418150 ]
Andrew Zhang commented on HARMONY-675:
--------------------------------------
Hello George,
The fix looks fine, many thanks!
Best regards,
Andrew
> [classlib][nio] Refactor ServerSocketAdapter.accept(Socket, SocketChannelImpl) in o.a.h.nio.internal.ServerSocketChannelImpl
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-675
> URL: http://issues.apache.org/jira/browse/HARMONY-675
> Project: Harmony
> Type: Bug
> Components: Classlib
> Reporter: Andrew Zhang
> Assignee: George Harley
> Priority: Minor
> Attachments: nio.diff
>
> There are serveral problems in ServerSocketAdapter.accept(Socket, SocketChannelImpl) method:
> 1. The modifier should be private, not public. As spec says: "The returned object will not declare any public methods that are not declared in the ServerSocket class."
> 2. One unnecessary FIXME.
> 3. Some unneccessray code.
> I'll upload a patch soon. Thanks!
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira