You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by vi...@apache.org on 2015/03/09 18:51:28 UTC

mesos git commit: MESOS-2426 developer guide improvements.

Repository: mesos
Updated Branches:
  refs/heads/master 1eb4f7d8c -> a0a5f0ae7


MESOS-2426 developer guide improvements.

1. Add a new line for the user to run 'rbt status' to log into RB.
2. Change 'git co' (technically invalid) to 'git checkout'.

Review: https://reviews.apache.org/r/31638


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/a0a5f0ae
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/a0a5f0ae
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/a0a5f0ae

Branch: refs/heads/master
Commit: a0a5f0ae710c88c7d9c5decc8bbbe6c30c2c9048
Parents: 1eb4f7d
Author: Aaron Bell <aa...@gmail.com>
Authored: Mon Mar 9 10:50:39 2015 -0700
Committer: Vinod Kone <vi...@gmail.com>
Committed: Mon Mar 9 10:50:39 2015 -0700

----------------------------------------------------------------------
 docs/mesos-developers-guide.md | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/a0a5f0ae/docs/mesos-developers-guide.md
----------------------------------------------------------------------
diff --git a/docs/mesos-developers-guide.md b/docs/mesos-developers-guide.md
index 0a30587..0ba9dbe 100644
--- a/docs/mesos-developers-guide.md
+++ b/docs/mesos-developers-guide.md
@@ -46,8 +46,8 @@ layout: documentation
 9. Make sure to pull in any changes that have been committed to master branch. Using Git, do this via something like:
     1. `git checkout master`
     2. `git pull`
-    3. `git co my_branch`
-    4. Check the output of `git diff master` and make sure it lists only your changes. If other changes you did not make are listed, try a rebase to bring your branch up to date with master.
+    3. `git checkout my_branch`
+    4. Check the output of `git diff master` and make sure it lists only your changes. If other changes you did not make are listed, try `git rebase master` to bring your branch up to date with master.
 
 ### Submit your patch
 1. You're ready to submit your patch for review!
@@ -55,10 +55,11 @@ layout: documentation
     2. The easiest (and recommended) way to submit reviews is through `post-reviews.py` a wrapper around post-review.
     3. First, install post-review. [See Instructions](http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/)
     4. Configure post-review. The easiest method is to symlink to the sample config: ln -s support/reviewboardrc .reviewboardrc
-    5. From your local branch run `support/post-reviews.py`.
-    6. Note that `post-reviews.py` creates a new review for every commit on your branch that is different from the `master`.
-    7. Be sure to add your JIRA issue id (e.g. MESOS-01) to the field labeled "Bugs" (this will automatically link)
-    8. Under "Description" in addition to details about your changes, include a description of any wiki documentation pages need to be added, or are affected by your changes (e.g. did you change or add any configuration options/flags? Did you add a new binary?)
+    5. Log into Review Board from the command line: run `rbt status`
+    6. From your local branch run `support/post-reviews.py`.
+    7. Note that `post-reviews.py` creates a new review for every commit on your branch that is different from the `master`.
+    8. Be sure to add your JIRA issue id (e.g. MESOS-01) to the field labeled "Bugs" (this will automatically link)
+    9. Under "Description" in addition to details about your changes, include a description of any documentation pages that need to be added, or are affected by your changes (e.g. did you change or add any configuration options/flags? Did you add a new binary?)
 
 2. Wait for a code review from another Mesos developer via Review Board, address their feedback and upload updated patches until you receive a "Ship It" from a Mesos committer.
     1. When addressing feedback, adjust your existing commit(s) instead of creating new commits, otherwise `post-reviews.py` will create a new review (`git rebase -i` is your friend).