You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by to...@apache.org on 2017/06/08 21:12:39 UTC
[3/4] kudu git commit: [catalog_manager_tsk-itest] remove KUDU-1294
workaround
[catalog_manager_tsk-itest] remove KUDU-1294 workaround
KUDU-1294 is fixed now, so it's possible to remove the workaround
for the memory accounting bug. Before KUDU-1294 was fixed, the
workaround was necessary because the test crashed sometimes due
DCHECK() firing in the destructor of the MemTracker class.
Change-Id: Ia371c222472e2deb43cf6b1471bf5ccb9394847d
Reviewed-on: http://gerrit.cloudera.org:8080/7101
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/cf686240
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/cf686240
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/cf686240
Branch: refs/heads/master
Commit: cf6862406a9bb4cddf0c96114b13bcc7890abff6
Parents: 3ed4a00
Author: Alexey Serbin <as...@cloudera.com>
Authored: Tue Jun 6 22:12:22 2017 -0700
Committer: Alexey Serbin <as...@cloudera.com>
Committed: Thu Jun 8 19:26:04 2017 +0000
----------------------------------------------------------------------
src/kudu/integration-tests/catalog_manager_tsk-itest.cc | 5 -----
1 file changed, 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/cf686240/src/kudu/integration-tests/catalog_manager_tsk-itest.cc
----------------------------------------------------------------------
diff --git a/src/kudu/integration-tests/catalog_manager_tsk-itest.cc b/src/kudu/integration-tests/catalog_manager_tsk-itest.cc
index 656d15a..2b201c2 100644
--- a/src/kudu/integration-tests/catalog_manager_tsk-itest.cc
+++ b/src/kudu/integration-tests/catalog_manager_tsk-itest.cc
@@ -65,11 +65,6 @@ class CatalogManagerTskITest : public KuduTest {
// Add common flags for both masters and tservers.
const vector<string> common_flags = {
Substitute("--raft_heartbeat_interval_ms=$0", hb_interval_ms_),
- // Added a workaround for memory accounting bug, otherwise the assertion
- // from MemTracker destructor fires in rare cases. Since the memory
- // accounting code is slated for revamping, let's disable the memory
- // tracking for this test.
- "--tablet_transaction_memory_limit_mb=-1",
};
copy(common_flags.begin(), common_flags.end(),
back_inserter(cluster_opts_.extra_master_flags));