[GitHub] [incubator-doris-manager] songchuangyuan commented on a diff in pull request #41: [fix] encrypt doris password

[GitBox <gi...@apache.org>]

songchuangyuan commented on code in PR #41:
URL: https://github.com/apache/incubator-doris-manager/pull/41#discussion_r848220723


##########
manager/general/src/main/java/org/apache/doris/stack/util/CredsUtil.java:
##########
@@ -34,9 +34,9 @@
 public class CredsUtil {
 
     /**
-    * Encrypt Key
-    * AES must be 128 bits
-    */
+     * Encrypt Key
+     * AES must be 128 bits
+     */
     private static final String ENCRYPT_KEY = "12dfA67887iyW321";

Review Comment:
   If the private key is directly fixed in the code, it may not work. For the time being, do you want to put it in the configuration file



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org