You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/27 04:46:14 UTC
[GitHub] [shardingsphere] terrymanu opened a new issue, #22453: Remove SQLStatement log for SQLLogger
terrymanu opened a new issue, #22453:
URL: https://github.com/apache/shardingsphere/issues/22453
The SQLStatement log is unnecessary for now. I want to discuss remove it at all.
The tasks are:
- [ ] Remove log from SQLLogger;
- [ ] Remove all @ToString annotation on SQLStatement and SQLSegment class;
- [ ] Remove last item of parser code conduct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #22453: Remove SQLStatement log in SQLLogger
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #22453:
URL: https://github.com/apache/shardingsphere/issues/22453#issuecomment-1328428313
Good idea, the SQLStatement log looks useless now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #22453: Remove SQLStatement log in SQLLogger
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #22453:
URL: https://github.com/apache/shardingsphere/issues/22453#issuecomment-1334645723
> Great, does anybody want to fix the issue?
I will fix it today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] smartbetter commented on issue #22453: Remove SQLStatement log in SQLLogger
Posted by GitBox <gi...@apache.org>.
smartbetter commented on issue #22453:
URL: https://github.com/apache/shardingsphere/issues/22453#issuecomment-1328193598
`SQLStatement log` prints too much, easy to cause disk waste.
Remove `SQLStatement log` in `SQLLogger` is Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #22453: Remove SQLStatement log in SQLLogger
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #22453:
URL: https://github.com/apache/shardingsphere/issues/22453#issuecomment-1334849687
@yx9o OK, then I will assign it to you, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang commented on issue #22453: Remove SQLStatement log in SQLLogger
Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on issue #22453:
URL: https://github.com/apache/shardingsphere/issues/22453#issuecomment-1328275194
+1
There is already `Logic SQL` in the log, if users need a statement, they can get it by parsing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #22453: Remove SQLStatement log in SQLLogger
Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #22453:
URL: https://github.com/apache/shardingsphere/issues/22453#issuecomment-1333949045
Great, does anybody want to fix the issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] yx9o commented on issue #22453: Remove SQLStatement log in SQLLogger
Posted by GitBox <gi...@apache.org>.
yx9o commented on issue #22453:
URL: https://github.com/apache/shardingsphere/issues/22453#issuecomment-1334846045
@RaigorJiang Hey, I want to finish it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #22453: Remove SQLStatement log in SQLLogger
Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #22453: Remove SQLStatement log in SQLLogger
URL: https://github.com/apache/shardingsphere/issues/22453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org