You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/23 20:44:08 UTC

[GitHub] [arrow-rs] alamb commented on a diff in pull request #3910: Add OffsetBuffer::new

alamb commented on code in PR #3910:
URL: https://github.com/apache/arrow-rs/pull/3910#discussion_r1146813127


##########
arrow-buffer/src/buffer/offset.rs:
##########
@@ -24,6 +24,22 @@ use std::ops::Deref;
 pub struct OffsetBuffer<O: ArrowNativeType>(ScalarBuffer<O>);
 
 impl<O: ArrowNativeType> OffsetBuffer<O> {
+    /// Create a new [`OffsetBuffer`] from the provided [`ScalarBuffer`]
+    ///
+    /// # Panics
+    ///
+    /// Panics if `buffer` is not a non-empty buffer containing

Review Comment:
   👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org