[GitHub] [airflow] uranusjr commented on a change in pull request #17137: [Airflow 13779] use provided parameters in the wait_for_pipeline_state hook

[GitBox <gi...@apache.org>]

uranusjr commented on a change in pull request #17137:
URL: https://github.com/apache/airflow/pull/17137#discussion_r685778883



##########
File path: tests/providers/google/cloud/hooks/test_datafusion.py
##########
@@ -197,13 +196,6 @@ def test_start_pipeline(self, mock_wait_for_pipeline_state, mock_request, hook):
         mock_request.assert_called_once_with(
             url=f"{INSTANCE_URL}/v3/namespaces/default/start", method="POST", body=body
         )
-        mock_wait_for_pipeline_state.assert_called_once_with(
-            instance_url=INSTANCE_URL,
-            namespace="default",
-            pipeline_name=PIPELINE_NAME,
-            pipeline_id=run_id,
-            success_states=SUCCESS_STATES + [PipelineStates.RUNNING],
-        )

Review comment:
       Since we removed this, should a case be added on the operator tests to make sure this is called?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org