You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2017/03/18 16:23:41 UTC

[GitHub] zeppelin pull request #2155: [HOTFIX] Dynamic form in python interpreter

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/zeppelin/pull/2155

    [HOTFIX] Dynamic form in python interpreter

    ### What is this PR for?
    https://github.com/apache/zeppelin/pull/2106 rewrote python interpreter. But dynamic form feature is not rewritten correctly.
    
    ### What type of PR is it?
    Hot Fix
    
    ### Todos
    * [x] - Bring dynamic form back
    
    ### What is the Jira issue?
    https://github.com/apache/zeppelin/pull/2106 
    
    ### How should this be tested?
    run
    
    ```
    %python
    print("Hello "+z.input("name", "sun"))
    ```
    
    ```
    %python
    print("Hello "+z.select("day", [("1","mon"),
                                    ("2","tue"),
                                    ("3","wed"),
                                    ("4","thurs"),
                                    ("5","fri"),
                                    ("6","sat"),
                                    ("7","sun")]))
    ```
    
    ```
    %python
    options = [("apple","Apple"), ("banana","Banana"), ("orange","Orange")]
    print("Hello "+ " and ".join(z.checkbox("fruit", options, ["apple"])))
    ```
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin python_get_interpreter_context

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2155
    
----
commit ab80f2ba4bc2f6972651d443d28ea9c29e909e94
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-18T16:17:36Z

    implement dynamic form

commit 844f1bdc4e2008221588b915a186258fb4dfbcb1
Author: Lee moon soo <mo...@apache.org>
Date:   2017-03-18T16:17:44Z

    Expose a method to get InterpreterOutput, so user can call InterpreterOutput.clear()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2155: [HOTFIX] Dynamic form in python interpreter

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2155
  
    Merge to master and branch-0.7 as a hotfix.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2155: [HOTFIX] Dynamic form in python interpreter

Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:

    https://github.com/apache/zeppelin/pull/2155
  
    Tested both with & without this patch. It works well now. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2155: [HOTFIX] Dynamic form in python interpreter

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2155


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---