You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wankai123 (via GitHub)" <gi...@apache.org> on 2024/01/09 09:58:58 UTC
[PR] Support Service Hierarchy auto matching. [skywalking]
wankai123 opened a new pull request, #11743:
URL: https://github.com/apache/skywalking/pull/11743
relate to [11669](https://github.com/apache/skywalking/discussions/11669)
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Service Hierarchy auto matching. [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #11743:
URL: https://github.com/apache/skywalking/pull/11743#discussion_r1446063970
##########
oap-server/server-starter/src/main/resources/hierarchy-definition.yml:
##########
@@ -13,17 +13,34 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Define the hierarchy of layers, the layers under the specific layer are lower of the layer.
+# Define the hierarchy of service layers, the layers under the specific layer are related lower of the layer.
+# The relation could have a matching rule for auto matching, which are defined in the `auto-matching-rules` section.
# All the layers are defined in the file `org.apache.skywalking.oap.server.core.analysis.Layers.java`.
-MESH:
- - MESH_DP
- - K8S_SERVICE
- - K8S
+hierarchy:
+ MESH:
+ MESH_DP: name
+ K8S_SERVICE: short-name
-MESH_DP:
- - K8S_SERVICE
- - K8S
+ MESH_DP:
+ K8S_SERVICE: short-name
+
+ GENERAL:
+ K8S_SERVICE: lower-short-name-remove-ns
+
+ MYSQL:
+ K8S_SERVICE: lower-short-name-remove-ns
+
+ VIRTUAL_DATABASE:
+ MYSQL: ~
Review Comment:
What does `~` mean?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Service Hierarchy auto matching. [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #11743:
URL: https://github.com/apache/skywalking/pull/11743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Service Hierarchy auto matching. [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #11743:
URL: https://github.com/apache/skywalking/pull/11743#discussion_r1445908886
##########
docs/en/swip/SWIP-1.md:
##########
@@ -116,44 +116,73 @@ type Node {
# The service hierarchy of the node.
serviceHierarchy: ServiceHierarchy!
}
-
-# Node in ServiceInstanceTopology
-type ServiceInstanceNode {
- ...
- # The service instance hierarchy of the node.
- instanceHierarchy: InstanceHierarchy!
-}
+```
## New data models
- service_hierarchy_relation
| Column name | Data type | Description |
- |-----------------------|-----------|-------------------------------------------------------------|
- | id | String | entityId |
- | entity_id | String | serviceId.servicelayer-relatedServiceId.relatedServiceLayer |
- | service_id | String | |
- | service_layer | int | service layer value |
- | related_service_id | String | |
- | related_service_layer | int | related service layer value |
+ |-----------------------|-----------|-------------------------------------------------------------|
+ | id | String | serviceId.servicelayer-relatedServiceId.relatedServiceLayer |
+ | service_id | String | upper service id |
+ | service_layer | int | upper service layer value |
+ | related_service_id | String | lower service id |
+ | related_service_layer | int | lower service layer value |
| time_bucket | long | |
- instance_hierarchy_relation
| Column name | Data type | Description |
- |-----------------------|-----------|--------------------------------------------------------------|
- | id | String | entityId |
- | entity_id | String | instanceId.servicelayer-relateInstanceId.relatedServiceLayer |
- | instance_id | String | |
- | service_layer | int | service layer value |
- | related_instance_id | String | |
- | related_service_layer | int | related service layer value |
+ |-----------------------|-----------|--------------------------------------------------------------|
+ | id | String | instanceId.servicelayer-relateInstanceId.relatedServiceLayer |
+ | instance_id | String | upper instance id |
+ | service_layer | int | upper service layer value |
+ | related_instance_id | String | lower instance id |
+ | related_service_layer | int | lower service layer value |
| time_bucket | long | |
## Internal APIs
Internal APIs should be exposed in the Core module to support building the hierarchy relationship.
```java
-public void toServiceHierarchyRelation(String serviceName, Layer serviceLayer, String relatedServiceName, Layer relatedServiceLayer);
-public void toInstanceHierarchyRelation(String instanceName, String serviceName, Layer serviceLayer, String relatedInstanceName, String relatedServiceName, Layer relateServiceLayer);
+public void toServiceHierarchyRelation(String upperServiceName, Layer upperServiceLayer, String lowerServiceName, Layer lowerServiceLayer);
+public void toInstanceHierarchyRelation(String upperInstanceName, String upperServiceName, Layer upperServiceLayer, String lowerInstanceName, String lowerServiceName, Layer lowerServiceLayer);
+```
+
+## Hierarchy Definition
+All layers hierarchy relations are defined in the `hierarchy-definition.yml` file.
+OAP will check the hierarchy relations before building and use the matching rules to auto match the relations. Here is an example:
+
+```yaml
+# Define the hierarchy of service layers, the layers under the specific layer are related lower of the layer.
+# The relation could have a matching rule for auto matching, which are defined in the `auto-matching-rules` section.
+# All the layers are defined in the file `org.apache.skywalking.oap.server.core.analysis.Layers.java`.
+
+hierarchy:
+ MESH:
+ MESH_DP: name
+ K8S_SERVICE: short-name
+
+ MESH_DP:
+ K8S_SERVICE: short-name
+
+ GENERAL:
+ K8S_SERVICE: lower-short-name-remove-ns
+
+ MYSQL:
+ K8S_SERVICE: lower-short-name-remove-ns
+
+ VIRTUAL_DATABASE:
+ MYSQL: ~
+
+# Use Groovy script to define the matching rules, the input parameters are the upper service(u) and the lower service(l) and the return value is a boolean.
+# which are used to match the relation between the upper service(u) and the lower service(l) on the different layers.
+auto-matching-rules:
+ # the name of the upper service is equal to the name of the lower service
+ name: "{ (u, l) -> u.name == l.name }"
+ # the short name of the upper service is equal to the short name of the lower service
+ short-name: "{ (u, l) -> u.shortName == l.shortName }"
+ # remove the namespace from the lower service short name
+ lower-short-name-remove-ns: "{ (u, l) -> u.shortName == l.shortName.substring(0, l.shortName.lastIndexOf('.')) }"
Review Comment:
@yswdqz This is another groovy kernel use case in v10. This is new one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Service Hierarchy auto matching. [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #11743:
URL: https://github.com/apache/skywalking/pull/11743#discussion_r1446109852
##########
oap-server/server-starter/src/main/resources/hierarchy-definition.yml:
##########
@@ -13,17 +13,34 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Define the hierarchy of layers, the layers under the specific layer are lower of the layer.
+# Define the hierarchy of service layers, the layers under the specific layer are related lower of the layer.
+# The relation could have a matching rule for auto matching, which are defined in the `auto-matching-rules` section.
# All the layers are defined in the file `org.apache.skywalking.oap.server.core.analysis.Layers.java`.
-MESH:
- - MESH_DP
- - K8S_SERVICE
- - K8S
+hierarchy:
+ MESH:
+ MESH_DP: name
+ K8S_SERVICE: short-name
-MESH_DP:
- - K8S_SERVICE
- - K8S
+ MESH_DP:
+ K8S_SERVICE: short-name
+
+ GENERAL:
+ K8S_SERVICE: lower-short-name-remove-ns
+
+ MYSQL:
+ K8S_SERVICE: lower-short-name-remove-ns
+
+ VIRTUAL_DATABASE:
+ MYSQL: ~
Review Comment:
It means there is no auto rule, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Service Hierarchy auto matching. [skywalking]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #11743:
URL: https://github.com/apache/skywalking/pull/11743#discussion_r1445972232
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/hierarchy/HierarchyService.java:
##########
@@ -60,84 +67,149 @@ private Map<String, List<String>> getHierarchyDefinition() {
return hierarchyDefinition;
}
+ private MetadataQueryService getMetadataQueryService() {
+ if (metadataQueryService == null) {
+ this.metadataQueryService = moduleManager.find(CoreModule.NAME)
+ .provider()
+ .getService(MetadataQueryService.class);
+ }
+ return metadataQueryService;
+ }
+
/**
* Build the hierarchy relation between the 2 services. the `serviceLayer` and `relatedServiceLayer` hierarchy
- * relations should be defined in `config/hierarchy-definition.yml`. Generally, if service A and service B could detect
- * each other, then build the hierarchy in one side is enough.
+ * relations should be defined in `config/hierarchy-definition.yml`.
*
- * @param serviceName the name of the source service (self)
- * @param serviceLayer the layer of the source service
- * @param relatedServiceName the name of the detected related service
- * @param relatedServiceLayer the layer of the detected related service
+ * @param upperServiceName the name of the service
+ * @param upperServiceLayer the layer of the service
+ * @param lowerServiceName the name of the lower service
+ * @param lowerServiceLayer the layer of the lower service
*/
- public void toServiceHierarchyRelation(String serviceName,
- Layer serviceLayer,
- String relatedServiceName,
- Layer relatedServiceLayer) {
+ public void toServiceHierarchyRelation(String upperServiceName,
+ Layer upperServiceLayer,
+ String lowerServiceName,
+ Layer lowerServiceLayer) {
if (!this.isEnableHierarchy) {
return;
}
- if (!checkHierarchyDefinition(serviceLayer, relatedServiceLayer)) {
+ Map<String, HierarchyDefinitionService.MatchingRule> lowerLayers = getHierarchyDefinition().get(upperServiceLayer.name());
+ if (lowerLayers == null || !lowerLayers.containsKey(lowerServiceLayer.name())) {
+ log.error("upperServiceLayer " + upperServiceLayer.name() + " or lowerServiceLayer " + lowerServiceLayer.name()
+ + " is not defined in hierarchy-definition.yml.");
return;
}
- ServiceHierarchyRelation serviceHierarchy = new ServiceHierarchyRelation();
- serviceHierarchy.setServiceName(serviceName);
- serviceHierarchy.setServiceLayer(serviceLayer);
- serviceHierarchy.setRelatedServiceName(relatedServiceName);
- serviceHierarchy.setRelatedServiceLayer(relatedServiceLayer);
- serviceHierarchy.setTimeBucket(TimeBucket.getMinuteTimeBucket(System.currentTimeMillis()));
- this.getSourceReceiver().receive(serviceHierarchy);
+ autoMatchingServiceRelation(upperServiceName, upperServiceLayer, lowerServiceName, lowerServiceLayer);
}
/**
* Build the hierarchy relation between the 2 instances. the `serviceLayer` and `relatedServiceLayer` hierarchy
- * relations should be defined in `config/hierarchy-definition.yml`. Generally, if instance A and instance B could detect
- * each other, then build the hierarchy in one side is enough.
+ * relations should be defined in `config/hierarchy-definition.yml`.
*
- * @param instanceName the name of the source instance (self)
- * @param serviceName the name of the source service (self)
- * @param serviceLayer the layer of the source service
- * @param relatedInstanceName the name of the detected related instance
- * @param relatedServiceName the name of the detected related service
- * @param relatedServiceLayer the layer of the detected related service
+ * @param upperInstanceName the name of the upper instance
+ * @param upperServiceName the name of the upper service
+ * @param upperServiceLayer the layer of the upper service
+ * @param lowerInstanceName the name of the lower related instance
+ * @param lowerServiceName the name of the lower related service
+ * @param lowerServiceLayer the layer of the lower related service
*/
- public void toInstanceHierarchyRelation(String instanceName,
- String serviceName,
- Layer serviceLayer,
- String relatedInstanceName,
- String relatedServiceName,
- Layer relatedServiceLayer) {
+ public void toInstanceHierarchyRelation(String upperInstanceName,
+ String upperServiceName,
+ Layer upperServiceLayer,
+ String lowerInstanceName,
+ String lowerServiceName,
+ Layer lowerServiceLayer) {
if (!this.isEnableHierarchy) {
return;
}
- if (!checkHierarchyDefinition(serviceLayer, relatedServiceLayer)) {
+ Map<String, HierarchyDefinitionService.MatchingRule> lowerLayers = getHierarchyDefinition().get(upperServiceLayer.name());
+ if (lowerLayers == null || !lowerLayers.containsKey(lowerServiceLayer.name())) {
+ log.error("upperServiceLayer " + upperServiceLayer.name() + " or lowerServiceLayer " + lowerServiceLayer.name()
+ + " is not defined in hierarchy-definition.yml.");
return;
}
+
+ buildInstanceHierarchyRelation(upperInstanceName, upperServiceName, upperServiceLayer, lowerInstanceName,
+ lowerServiceName, lowerServiceLayer);
+ }
+
+ public void startAutoMatchingServiceHierarchy() {
+ if (!this.isEnableHierarchy) {
+ return;
+ }
Review Comment:
Let's move this check to the provider `CoreModuleProvider` so we don't bother to initialize everything that is never used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Service Hierarchy auto matching. [skywalking]
Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on code in PR #11743:
URL: https://github.com/apache/skywalking/pull/11743#discussion_r1446111282
##########
oap-server/server-starter/src/main/resources/hierarchy-definition.yml:
##########
@@ -13,17 +13,34 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Define the hierarchy of layers, the layers under the specific layer are lower of the layer.
+# Define the hierarchy of service layers, the layers under the specific layer are related lower of the layer.
+# The relation could have a matching rule for auto matching, which are defined in the `auto-matching-rules` section.
# All the layers are defined in the file `org.apache.skywalking.oap.server.core.analysis.Layers.java`.
-MESH:
- - MESH_DP
- - K8S_SERVICE
- - K8S
+hierarchy:
+ MESH:
+ MESH_DP: name
+ K8S_SERVICE: short-name
-MESH_DP:
- - K8S_SERVICE
- - K8S
+ MESH_DP:
+ K8S_SERVICE: short-name
+
+ GENERAL:
+ K8S_SERVICE: lower-short-name-remove-ns
+
+ MYSQL:
+ K8S_SERVICE: lower-short-name-remove-ns
+
+ VIRTUAL_DATABASE:
+ MYSQL: ~
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Service Hierarchy auto matching. [skywalking]
Posted by "wankai123 (via GitHub)" <gi...@apache.org>.
wankai123 commented on code in PR #11743:
URL: https://github.com/apache/skywalking/pull/11743#discussion_r1446066973
##########
oap-server/server-starter/src/main/resources/hierarchy-definition.yml:
##########
@@ -13,17 +13,34 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-# Define the hierarchy of layers, the layers under the specific layer are lower of the layer.
+# Define the hierarchy of service layers, the layers under the specific layer are related lower of the layer.
+# The relation could have a matching rule for auto matching, which are defined in the `auto-matching-rules` section.
# All the layers are defined in the file `org.apache.skywalking.oap.server.core.analysis.Layers.java`.
-MESH:
- - MESH_DP
- - K8S_SERVICE
- - K8S
+hierarchy:
+ MESH:
+ MESH_DP: name
+ K8S_SERVICE: short-name
-MESH_DP:
- - K8S_SERVICE
- - K8S
+ MESH_DP:
+ K8S_SERVICE: short-name
+
+ GENERAL:
+ K8S_SERVICE: lower-short-name-remove-ns
+
+ MYSQL:
+ K8S_SERVICE: lower-short-name-remove-ns
+
+ VIRTUAL_DATABASE:
+ MYSQL: ~
Review Comment:
It's represent `null` in yaml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Service Hierarchy auto matching. [skywalking]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on code in PR #11743:
URL: https://github.com/apache/skywalking/pull/11743#discussion_r1445972232
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/hierarchy/HierarchyService.java:
##########
@@ -60,84 +67,149 @@ private Map<String, List<String>> getHierarchyDefinition() {
return hierarchyDefinition;
}
+ private MetadataQueryService getMetadataQueryService() {
+ if (metadataQueryService == null) {
+ this.metadataQueryService = moduleManager.find(CoreModule.NAME)
+ .provider()
+ .getService(MetadataQueryService.class);
+ }
+ return metadataQueryService;
+ }
+
/**
* Build the hierarchy relation between the 2 services. the `serviceLayer` and `relatedServiceLayer` hierarchy
- * relations should be defined in `config/hierarchy-definition.yml`. Generally, if service A and service B could detect
- * each other, then build the hierarchy in one side is enough.
+ * relations should be defined in `config/hierarchy-definition.yml`.
*
- * @param serviceName the name of the source service (self)
- * @param serviceLayer the layer of the source service
- * @param relatedServiceName the name of the detected related service
- * @param relatedServiceLayer the layer of the detected related service
+ * @param upperServiceName the name of the service
+ * @param upperServiceLayer the layer of the service
+ * @param lowerServiceName the name of the lower service
+ * @param lowerServiceLayer the layer of the lower service
*/
- public void toServiceHierarchyRelation(String serviceName,
- Layer serviceLayer,
- String relatedServiceName,
- Layer relatedServiceLayer) {
+ public void toServiceHierarchyRelation(String upperServiceName,
+ Layer upperServiceLayer,
+ String lowerServiceName,
+ Layer lowerServiceLayer) {
if (!this.isEnableHierarchy) {
return;
}
- if (!checkHierarchyDefinition(serviceLayer, relatedServiceLayer)) {
+ Map<String, HierarchyDefinitionService.MatchingRule> lowerLayers = getHierarchyDefinition().get(upperServiceLayer.name());
+ if (lowerLayers == null || !lowerLayers.containsKey(lowerServiceLayer.name())) {
+ log.error("upperServiceLayer " + upperServiceLayer.name() + " or lowerServiceLayer " + lowerServiceLayer.name()
+ + " is not defined in hierarchy-definition.yml.");
return;
}
- ServiceHierarchyRelation serviceHierarchy = new ServiceHierarchyRelation();
- serviceHierarchy.setServiceName(serviceName);
- serviceHierarchy.setServiceLayer(serviceLayer);
- serviceHierarchy.setRelatedServiceName(relatedServiceName);
- serviceHierarchy.setRelatedServiceLayer(relatedServiceLayer);
- serviceHierarchy.setTimeBucket(TimeBucket.getMinuteTimeBucket(System.currentTimeMillis()));
- this.getSourceReceiver().receive(serviceHierarchy);
+ autoMatchingServiceRelation(upperServiceName, upperServiceLayer, lowerServiceName, lowerServiceLayer);
}
/**
* Build the hierarchy relation between the 2 instances. the `serviceLayer` and `relatedServiceLayer` hierarchy
- * relations should be defined in `config/hierarchy-definition.yml`. Generally, if instance A and instance B could detect
- * each other, then build the hierarchy in one side is enough.
+ * relations should be defined in `config/hierarchy-definition.yml`.
*
- * @param instanceName the name of the source instance (self)
- * @param serviceName the name of the source service (self)
- * @param serviceLayer the layer of the source service
- * @param relatedInstanceName the name of the detected related instance
- * @param relatedServiceName the name of the detected related service
- * @param relatedServiceLayer the layer of the detected related service
+ * @param upperInstanceName the name of the upper instance
+ * @param upperServiceName the name of the upper service
+ * @param upperServiceLayer the layer of the upper service
+ * @param lowerInstanceName the name of the lower related instance
+ * @param lowerServiceName the name of the lower related service
+ * @param lowerServiceLayer the layer of the lower related service
*/
- public void toInstanceHierarchyRelation(String instanceName,
- String serviceName,
- Layer serviceLayer,
- String relatedInstanceName,
- String relatedServiceName,
- Layer relatedServiceLayer) {
+ public void toInstanceHierarchyRelation(String upperInstanceName,
+ String upperServiceName,
+ Layer upperServiceLayer,
+ String lowerInstanceName,
+ String lowerServiceName,
+ Layer lowerServiceLayer) {
if (!this.isEnableHierarchy) {
return;
}
- if (!checkHierarchyDefinition(serviceLayer, relatedServiceLayer)) {
+ Map<String, HierarchyDefinitionService.MatchingRule> lowerLayers = getHierarchyDefinition().get(upperServiceLayer.name());
+ if (lowerLayers == null || !lowerLayers.containsKey(lowerServiceLayer.name())) {
+ log.error("upperServiceLayer " + upperServiceLayer.name() + " or lowerServiceLayer " + lowerServiceLayer.name()
+ + " is not defined in hierarchy-definition.yml.");
return;
}
+
+ buildInstanceHierarchyRelation(upperInstanceName, upperServiceName, upperServiceLayer, lowerInstanceName,
+ lowerServiceName, lowerServiceLayer);
+ }
+
+ public void startAutoMatchingServiceHierarchy() {
+ if (!this.isEnableHierarchy) {
+ return;
+ }
Review Comment:
Let's move this check to the provider `CoreModuleProvider` so we don't bother to initialize everything that is never used if `isEnableHierarchy` is false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support Service Hierarchy auto matching. [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng closed pull request #11743: Support Service Hierarchy auto matching.
URL: https://github.com/apache/skywalking/pull/11743
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org