You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Greg Stein <gs...@gmail.com> on 2019/12/03 22:15:13 UTC
utf8proc required
Hey all,
I was setting up a new chromebook, with a completely barren Ubuntu install
(using ChromeOS linux beta feature). utf8proc was not installed, and the
configure failed.
This requirement is not listed in INSTALL.
I don't know enough about the use of utf8proc to know whether it *should*
be required, or if it *should* be optional in ./configure.
Either way, utf8proc should be documented in INSTALL.
Cheers,
-g
Re: utf8proc required
Posted by Branko Čibej <br...@apache.org>.
On 03.12.2019 23:15, Greg Stein wrote:
> Hey all,
>
> I was setting up a new chromebook, with a completely barren Ubuntu
> install (using ChromeOS linux beta feature). utf8proc was not
> installed, and the configure failed.
>
> This requirement is not listed in INSTALL.
>
> I don't know enough about the use of utf8proc to know whether it
> *should* be required, or if it *should* be optional in ./configure.
>
> Either way, utf8proc should be documented in INSTALL.
It's bundled, so not a required external dependency.
$ ./configure --help
...
--with-utf8proc=PREFIX|internal
look for utf8proc in PREFIX or use the internal code
...
But sure, it should be documented in INSTALL ... I think you might have
commit access to that? :)
-- Brane
Re: utf8proc required
Posted by Greg Stein <gs...@gmail.com>.
On Wed, Dec 4, 2019 at 11:38 PM Nathan Hartman <ha...@gmail.com>
wrote:
> On Wed, Dec 4, 2019 at 12:28 AM Greg Stein <gs...@gmail.com> wrote:
> > On Tue, Dec 3, 2019 at 10:41 PM Nathan Hartman <ha...@gmail.com>
> wrote:
> >> I'd prefer to put utf8proc toward the top of "Dependencies in Detail"
> >> because it is a required dependency. Currently I added it at the end,
> >> item 24. Moving it up will renumber most of the items. Should I do
> >> that?
> >
> >
> > +1 to group the required items, with the requisite renumbering for
> optionals.
>
> Done.
>
> r1870861 documents the required dependency on utf8proc without
> altering any other text.
>
> r1870862 moves the required dependencies SQLite, libz, and utf8proc to
> the top of the list and renumbers the list.
>
Thanks!
(and I like how you used two revs)
Cheers,
-g
Re: utf8proc required
Posted by Nathan Hartman <ha...@gmail.com>.
On Wed, Dec 4, 2019 at 12:28 AM Greg Stein <gs...@gmail.com> wrote:
> On Tue, Dec 3, 2019 at 10:41 PM Nathan Hartman <ha...@gmail.com> wrote:
>> I'd prefer to put utf8proc toward the top of "Dependencies in Detail"
>> because it is a required dependency. Currently I added it at the end,
>> item 24. Moving it up will renumber most of the items. Should I do
>> that?
>
>
> +1 to group the required items, with the requisite renumbering for optionals.
Done.
r1870861 documents the required dependency on utf8proc without
altering any other text.
r1870862 moves the required dependencies SQLite, libz, and utf8proc to
the top of the list and renumbers the list.
Cheers,
Nathan
Re: utf8proc required
Posted by Greg Stein <gs...@gmail.com>.
On Tue, Dec 3, 2019 at 10:41 PM Nathan Hartman <ha...@gmail.com>
wrote:
> On Tue, Dec 3, 2019 at 5:15 PM Greg Stein <gs...@gmail.com> wrote:
> > I was setting up a new chromebook, with a completely barren Ubuntu
> install (using ChromeOS linux beta feature). utf8proc was not installed,
> and the configure failed.
> >
> > This requirement is not listed in INSTALL.
>
> Good catch! Thank you for reporting.
>
> I propose to add the following (or similar) to INSTALL.
>
> I'd prefer to put utf8proc toward the top of "Dependencies in Detail"
> because it is a required dependency. Currently I added it at the end,
> item 24. Moving it up will renumber most of the items. Should I do
> that?
>
+1 to group the required items, with the requisite renumbering for
optionals.
... and:
On Tue, Dec 3, 2019 at 5:33 PM Branko Čibej <br...@apache.org> wrote:
>...
> It's bundled, so not a required external dependency.
>
Ah! Yeah... didn't know this. Daniel just made a change to point this out
at configure failure. I think we're good now, with that, and Nathan
applying his patch (above).
> $ ./configure --help
> ...
> --with-utf8proc=PREFIX|internal
> look for utf8proc in PREFIX or use the internal code
> ...
>
>
> But sure, it should be documented in INSTALL ... I think you might have
> commit access to that? :)
I certainly do. For nearly 20 years :p ... but as stated: I didn't know
which path/intent was appropriate. And Nathan beat me with a proposed
patch. I defer to him.
Thanks all, for the quick response and solutions!
Cheers,
-g
Re: utf8proc required
Posted by Nathan Hartman <ha...@gmail.com>.
On Tue, Dec 3, 2019 at 5:15 PM Greg Stein <gs...@gmail.com> wrote:
> I was setting up a new chromebook, with a completely barren Ubuntu install (using ChromeOS linux beta feature). utf8proc was not installed, and the configure failed.
>
> This requirement is not listed in INSTALL.
Good catch! Thank you for reporting.
I propose to add the following (or similar) to INSTALL.
I'd prefer to put utf8proc toward the top of "Dependencies in Detail"
because it is a required dependency. Currently I added it at the end,
item 24. Moving it up will renumber most of the items. Should I do
that?
Log:
[[[
INSTALL: Document required dependency on utf8proc
* INSTALL:
(Section I.B. "Dependency Overview")
Add bulletpoint for utf8proc.
(Section I.C. "Dependencies in Detail")
Document required dependency on utf8proc and relevant 'configure'
argument.
Found by: gstein
]]]
Patch:
[[[
Index: INSTALL
===================================================================
--- INSTALL (revision 1870785)
+++ INSTALL (working copy)
@@ -95,6 +95,11 @@
Subversion uses zlib for compressing binary differences.
These diff streams are used everywhere -- over the network,
in the repository, and in the client's working copy.
+
+ * utf8proc (REQUIRED for client and server)
+
+ Subversion uses utf8proc for UTF-8 support, including Unicode
+ normalization.
* Apache Serf (OPTIONAL for client)
@@ -607,7 +612,23 @@
script to download py3c and several other dependencies; see the
top of section I.C for more about get-deps.sh.
+ 24. utf8proc (REQUIRED)
+ Subversion uses utf8proc for UTF-8 support. Configure will
+ attempt to locate utf8proc by default using pkg-config and known
+ paths.
+
+ If it is installed in a non-standard location, then use:
+
+ --with-utf8proc=/path/to/libutf8proc
+
+ Alternatively, a copy of utf8proc comes bundled with the
+ Subversion sources. If configure should use the bundled copy,
+ use:
+
+ --with-utf8proc=internal
+
+
D. Documentation
The primary documentation for Subversion is the free book
]]]
Thoughts?
Thanks,
Nathan