You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flex.apache.org by er...@apache.org on 2014/10/15 08:53:39 UTC
git commit: [flex-tlf] [refs/heads/develop] - FLEX-34403 - fix "Right
arrow never works when text selected in TextInput" (credit: Neil Madsen)
Repository: flex-tlf
Updated Branches:
refs/heads/develop 553c899e5 -> 80f3042db
FLEX-34403 - fix "Right arrow never works when text selected in TextInput" (credit: Neil Madsen)
Signed-off-by: Erik de Bruin <er...@ixsoftware.nl>
Project: http://git-wip-us.apache.org/repos/asf/flex-tlf/repo
Commit: http://git-wip-us.apache.org/repos/asf/flex-tlf/commit/80f3042d
Tree: http://git-wip-us.apache.org/repos/asf/flex-tlf/tree/80f3042d
Diff: http://git-wip-us.apache.org/repos/asf/flex-tlf/diff/80f3042d
Branch: refs/heads/develop
Commit: 80f3042db978557183109deb8231a6d84853d657
Parents: 553c899
Author: Erik de Bruin <er...@ixsoftware.nl>
Authored: Wed Oct 15 08:53:26 2014 +0200
Committer: Erik de Bruin <er...@ixsoftware.nl>
Committed: Wed Oct 15 08:53:26 2014 +0200
----------------------------------------------------------------------
textLayout/src/flashx/textLayout/utils/NavigationUtil.as | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/80f3042d/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
----------------------------------------------------------------------
diff --git a/textLayout/src/flashx/textLayout/utils/NavigationUtil.as b/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
index 2ebb985..091ceda 100644
--- a/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
+++ b/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
@@ -1112,7 +1112,8 @@ package flashx.textLayout.utils
if (range.absoluteEnd >= flowComposer.damageAbsoluteStart - 1)
{
clampToFit(range, flowComposer.damageAbsoluteStart - 1);
- return true;
+ return false;
+ //return true;
}
if (flowComposer && flowComposer.numControllers)
{
Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34403 - fix
"Right arrow never works when text selected in TextInput" (credit: Neil
Madsen)
Posted by piotrz <pi...@gmail.com>.
I did quick look into the console output for flex-tlf and it looks like unit
test are not included in this build.
I see this: ant.bat -file build.xml main && exit %%ERRORLEVEL%%"'
Target should be "all" instead "main": ant.bat -file build.xml all && exit
%%ERRORLEVEL%%"'
Alex how can I change it ?
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-git-commit-flex-tlf-refs-heads-develop-FLEX-34403-fix-Right-arrow-never-works-when-text-selected--tp41400p41434.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34403 - fix
"Right arrow never works when text selected in TextInput" (credit: Neil
Madsen)
Posted by Alex Harui <ah...@adobe.com>.
Test results will definitely be helpful. Of course, we may not have tests
for every case in this code path. I spent a few minutes looking at the
patch and the entire file. I haven’t stepped through the test cases. I
can see why changing the return value could fix this test case, but if
someone is going to dig deeper, I would suggest trying to see if there are
cases where that code path should return the true. It looks like the
semantics of the return value has to do with whether the range gets
adjusted or not. Maybe clampToFit needs to return whether it adjusted the
range and that would dictate whether false is returned in the test case
scenario.
-Alex
On 10/15/14, 7:41 AM, "piotrz" <pi...@gmail.com> wrote:
>Erik,
>
>If you pushed it to the develop branch let's wait for jenkins build and
>see
>whether existing Unit Tests pass through without a problem on TLF. I think
>It will be also some information whether this patch break something or
>not.
>
>Piotr
>
>
>
>-----
>Apache Flex PMC
>piotrzarzycki21@gmail.com
>--
>View this message in context:
>http://apache-flex-development.2333347.n4.nabble.com/Re-git-commit-flex-tl
>f-refs-heads-develop-FLEX-34403-fix-Right-arrow-never-works-when-text-sele
>cted--tp41400p41416.html
>Sent from the Apache Flex Development mailing list archive at Nabble.com.
Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34403 - fix
"Right arrow never works when text selected in TextInput" (credit: Neil
Madsen)
Posted by piotrz <pi...@gmail.com>.
Erik,
If you pushed it to the develop branch let's wait for jenkins build and see
whether existing Unit Tests pass through without a problem on TLF. I think
It will be also some information whether this patch break something or not.
Piotr
-----
Apache Flex PMC
piotrzarzycki21@gmail.com
--
View this message in context: http://apache-flex-development.2333347.n4.nabble.com/Re-git-commit-flex-tlf-refs-heads-develop-FLEX-34403-fix-Right-arrow-never-works-when-text-selected--tp41400p41416.html
Sent from the Apache Flex Development mailing list archive at Nabble.com.
RE: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34403 - fix "Right arrow never works when text selected in TextInput" (credit: Neil Madsen)
Posted by Neil Madsen <li...@cranialinteractive.com>.
Agreed. I did track that through line by line in multiple scenarios but
there could be some cases I missed which is why I asked if someone with more
knowledge of TLF could take a look. The patch is super simple (changed a
true to false) so it's really easy to revert if needed.
Neil
-----Original Message-----
From: Erik de Bruin [mailto:erik@ixsoftware.nl]
Sent: October-15-14 5:24 AM
To: dev@flex.apache.org
Subject: Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34403 - fix
"Right arrow never works when text selected in TextInput" (credit: Neil
Madsen)
The patch is already applied. Feel free to revert if I missed something and
it turns out the "fix" breaks stuff (or doesn't fix the actual problem ;-))
EdB
On Wed, Oct 15, 2014 at 12:04 PM, Harbs <ha...@gmail.com> wrote:
> I will take a look at this next week and apply it if it's okay.
>
> On Oct 15, 2014, at 10:24 AM, Justin Mclean <ju...@me.com> wrote:
>
> > HI,
> >
> > Think this needs to be carefully tested before being applied, it
> > doesn't
> look like the correct fix to me (and I'd remove the commented out line).
> >
> > Anyone who knows TLF better than I have an opinion on this "fix"?
> >
> > Thanks,
> > Justin
> >
> > On 15 Oct 2014, at 5:53 pm, erikdebruin@apache.org wrote:
> >
> >> Repository: flex-tlf
> >> Updated Branches:
> >> refs/heads/develop 553c899e5 -> 80f3042db
> >>
> >>
> >> FLEX-34403 - fix "Right arrow never works when text selected in
> TextInput" (credit: Neil Madsen)
> >>
> >> Signed-off-by: Erik de Bruin <er...@ixsoftware.nl>
> >>
> >>
> >> Project: http://git-wip-us.apache.org/repos/asf/flex-tlf/repo
> >> Commit:
> >> http://git-wip-us.apache.org/repos/asf/flex-tlf/commit/80f3042d
> >> Tree: http://git-wip-us.apache.org/repos/asf/flex-tlf/tree/80f3042d
> >> Diff: http://git-wip-us.apache.org/repos/asf/flex-tlf/diff/80f3042d
> >>
> >> Branch: refs/heads/develop
> >> Commit: 80f3042db978557183109deb8231a6d84853d657
> >> Parents: 553c899
> >> Author: Erik de Bruin <er...@ixsoftware.nl>
> >> Authored: Wed Oct 15 08:53:26 2014 +0200
> >> Committer: Erik de Bruin <er...@ixsoftware.nl>
> >> Committed: Wed Oct 15 08:53:26 2014 +0200
> >>
> >> -------------------------------------------------------------------
> >> --- textLayout/src/flashx/textLayout/utils/NavigationUtil.as | 3
> >> ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >> -------------------------------------------------------------------
> >> ---
> >>
> >>
> >>
> http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/80f3042d/textLayo
> ut/src/flashx/textLayout/utils/NavigationUtil.as
> >> -------------------------------------------------------------------
> >> --- diff --git
> >> a/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> b/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> >> index 2ebb985..091ceda 100644
> >> --- a/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> >> +++ b/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> >> @@ -1112,7 +1112,8 @@ package flashx.textLayout.utils
> >> if (range.absoluteEnd >=
> flowComposer.damageAbsoluteStart - 1)
> >> {
> >> clampToFit(range,
> flowComposer.damageAbsoluteStart - 1);
> >> - return true;
> >> + return false;
> >> + //return true;
> >> }
> >> if (flowComposer && flowComposer.numControllers)
> >> {
> >>
> >
>
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34403 - fix
"Right arrow never works when text selected in TextInput" (credit: Neil Madsen)
Posted by Erik de Bruin <er...@ixsoftware.nl>.
The patch is already applied. Feel free to revert if I missed something and
it turns out the “fix” breaks stuff (or doesn’t fix the actual problem ;-))
EdB
On Wed, Oct 15, 2014 at 12:04 PM, Harbs <ha...@gmail.com> wrote:
> I will take a look at this next week and apply it if it’s okay.
>
> On Oct 15, 2014, at 10:24 AM, Justin Mclean <ju...@me.com> wrote:
>
> > HI,
> >
> > Think this needs to be carefully tested before being applied, it doesn't
> look like the correct fix to me (and I'd remove the commented out line).
> >
> > Anyone who knows TLF better than I have an opinion on this "fix"?
> >
> > Thanks,
> > Justin
> >
> > On 15 Oct 2014, at 5:53 pm, erikdebruin@apache.org wrote:
> >
> >> Repository: flex-tlf
> >> Updated Branches:
> >> refs/heads/develop 553c899e5 -> 80f3042db
> >>
> >>
> >> FLEX-34403 - fix "Right arrow never works when text selected in
> TextInput" (credit: Neil Madsen)
> >>
> >> Signed-off-by: Erik de Bruin <er...@ixsoftware.nl>
> >>
> >>
> >> Project: http://git-wip-us.apache.org/repos/asf/flex-tlf/repo
> >> Commit: http://git-wip-us.apache.org/repos/asf/flex-tlf/commit/80f3042d
> >> Tree: http://git-wip-us.apache.org/repos/asf/flex-tlf/tree/80f3042d
> >> Diff: http://git-wip-us.apache.org/repos/asf/flex-tlf/diff/80f3042d
> >>
> >> Branch: refs/heads/develop
> >> Commit: 80f3042db978557183109deb8231a6d84853d657
> >> Parents: 553c899
> >> Author: Erik de Bruin <er...@ixsoftware.nl>
> >> Authored: Wed Oct 15 08:53:26 2014 +0200
> >> Committer: Erik de Bruin <er...@ixsoftware.nl>
> >> Committed: Wed Oct 15 08:53:26 2014 +0200
> >>
> >> ----------------------------------------------------------------------
> >> textLayout/src/flashx/textLayout/utils/NavigationUtil.as | 3 ++-
> >> 1 file changed, 2 insertions(+), 1 deletion(-)
> >> ----------------------------------------------------------------------
> >>
> >>
> >>
> http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/80f3042d/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> >> ----------------------------------------------------------------------
> >> diff --git a/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> b/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> >> index 2ebb985..091ceda 100644
> >> --- a/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> >> +++ b/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> >> @@ -1112,7 +1112,8 @@ package flashx.textLayout.utils
> >> if (range.absoluteEnd >=
> flowComposer.damageAbsoluteStart - 1)
> >> {
> >> clampToFit(range,
> flowComposer.damageAbsoluteStart - 1);
> >> - return true;
> >> + return false;
> >> + //return true;
> >> }
> >> if (flowComposer && flowComposer.numControllers)
> >> {
> >>
> >
>
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34403 - fix "Right arrow never works when text selected in TextInput" (credit: Neil Madsen)
Posted by Harbs <ha...@gmail.com>.
I will take a look at this next week and apply it if it’s okay.
On Oct 15, 2014, at 10:24 AM, Justin Mclean <ju...@me.com> wrote:
> HI,
>
> Think this needs to be carefully tested before being applied, it doesn't look like the correct fix to me (and I'd remove the commented out line).
>
> Anyone who knows TLF better than I have an opinion on this "fix"?
>
> Thanks,
> Justin
>
> On 15 Oct 2014, at 5:53 pm, erikdebruin@apache.org wrote:
>
>> Repository: flex-tlf
>> Updated Branches:
>> refs/heads/develop 553c899e5 -> 80f3042db
>>
>>
>> FLEX-34403 - fix "Right arrow never works when text selected in TextInput" (credit: Neil Madsen)
>>
>> Signed-off-by: Erik de Bruin <er...@ixsoftware.nl>
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/flex-tlf/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/flex-tlf/commit/80f3042d
>> Tree: http://git-wip-us.apache.org/repos/asf/flex-tlf/tree/80f3042d
>> Diff: http://git-wip-us.apache.org/repos/asf/flex-tlf/diff/80f3042d
>>
>> Branch: refs/heads/develop
>> Commit: 80f3042db978557183109deb8231a6d84853d657
>> Parents: 553c899
>> Author: Erik de Bruin <er...@ixsoftware.nl>
>> Authored: Wed Oct 15 08:53:26 2014 +0200
>> Committer: Erik de Bruin <er...@ixsoftware.nl>
>> Committed: Wed Oct 15 08:53:26 2014 +0200
>>
>> ----------------------------------------------------------------------
>> textLayout/src/flashx/textLayout/utils/NavigationUtil.as | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/80f3042d/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
>> ----------------------------------------------------------------------
>> diff --git a/textLayout/src/flashx/textLayout/utils/NavigationUtil.as b/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
>> index 2ebb985..091ceda 100644
>> --- a/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
>> +++ b/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
>> @@ -1112,7 +1112,8 @@ package flashx.textLayout.utils
>> if (range.absoluteEnd >= flowComposer.damageAbsoluteStart - 1)
>> {
>> clampToFit(range, flowComposer.damageAbsoluteStart - 1);
>> - return true;
>> + return false;
>> + //return true;
>> }
>> if (flowComposer && flowComposer.numControllers)
>> {
>>
>
Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34403 - fix
"Right arrow never works when text selected in TextInput" (credit: Neil Madsen)
Posted by Erik de Bruin <er...@ixsoftware.nl>.
Have you tried it?
EdB
On Wed, Oct 15, 2014 at 9:24 AM, Justin Mclean <ju...@me.com> wrote:
> HI,
>
> Think this needs to be carefully tested before being applied, it doesn't
> look like the correct fix to me (and I'd remove the commented out line).
>
> Anyone who knows TLF better than I have an opinion on this "fix"?
>
> Thanks,
> Justin
>
> On 15 Oct 2014, at 5:53 pm, erikdebruin@apache.org wrote:
>
> > Repository: flex-tlf
> > Updated Branches:
> > refs/heads/develop 553c899e5 -> 80f3042db
> >
> >
> > FLEX-34403 - fix "Right arrow never works when text selected in
> TextInput" (credit: Neil Madsen)
> >
> > Signed-off-by: Erik de Bruin <er...@ixsoftware.nl>
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/flex-tlf/repo
> > Commit: http://git-wip-us.apache.org/repos/asf/flex-tlf/commit/80f3042d
> > Tree: http://git-wip-us.apache.org/repos/asf/flex-tlf/tree/80f3042d
> > Diff: http://git-wip-us.apache.org/repos/asf/flex-tlf/diff/80f3042d
> >
> > Branch: refs/heads/develop
> > Commit: 80f3042db978557183109deb8231a6d84853d657
> > Parents: 553c899
> > Author: Erik de Bruin <er...@ixsoftware.nl>
> > Authored: Wed Oct 15 08:53:26 2014 +0200
> > Committer: Erik de Bruin <er...@ixsoftware.nl>
> > Committed: Wed Oct 15 08:53:26 2014 +0200
> >
> > ----------------------------------------------------------------------
> > textLayout/src/flashx/textLayout/utils/NavigationUtil.as | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/80f3042d/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> > ----------------------------------------------------------------------
> > diff --git a/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> b/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> > index 2ebb985..091ceda 100644
> > --- a/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> > +++ b/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> > @@ -1112,7 +1112,8 @@ package flashx.textLayout.utils
> > if (range.absoluteEnd >=
> flowComposer.damageAbsoluteStart - 1)
> > {
> > clampToFit(range,
> flowComposer.damageAbsoluteStart - 1);
> > - return true;
> > + return false;
> > + //return true;
> > }
> > if (flowComposer && flowComposer.numControllers)
> > {
> >
>
>
--
Ix Multimedia Software
Jan Luykenstraat 27
3521 VB Utrecht
T. 06-51952295
I. www.ixsoftware.nl
Re: git commit: [flex-tlf] [refs/heads/develop] - FLEX-34403 - fix
"Right arrow never works when text selected in TextInput" (credit: Neil Madsen)
Posted by Justin Mclean <ju...@me.com>.
HI,
Think this needs to be carefully tested before being applied, it doesn't look like the correct fix to me (and I'd remove the commented out line).
Anyone who knows TLF better than I have an opinion on this "fix"?
Thanks,
Justin
On 15 Oct 2014, at 5:53 pm, erikdebruin@apache.org wrote:
> Repository: flex-tlf
> Updated Branches:
> refs/heads/develop 553c899e5 -> 80f3042db
>
>
> FLEX-34403 - fix "Right arrow never works when text selected in TextInput" (credit: Neil Madsen)
>
> Signed-off-by: Erik de Bruin <er...@ixsoftware.nl>
>
>
> Project: http://git-wip-us.apache.org/repos/asf/flex-tlf/repo
> Commit: http://git-wip-us.apache.org/repos/asf/flex-tlf/commit/80f3042d
> Tree: http://git-wip-us.apache.org/repos/asf/flex-tlf/tree/80f3042d
> Diff: http://git-wip-us.apache.org/repos/asf/flex-tlf/diff/80f3042d
>
> Branch: refs/heads/develop
> Commit: 80f3042db978557183109deb8231a6d84853d657
> Parents: 553c899
> Author: Erik de Bruin <er...@ixsoftware.nl>
> Authored: Wed Oct 15 08:53:26 2014 +0200
> Committer: Erik de Bruin <er...@ixsoftware.nl>
> Committed: Wed Oct 15 08:53:26 2014 +0200
>
> ----------------------------------------------------------------------
> textLayout/src/flashx/textLayout/utils/NavigationUtil.as | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/flex-tlf/blob/80f3042d/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> ----------------------------------------------------------------------
> diff --git a/textLayout/src/flashx/textLayout/utils/NavigationUtil.as b/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> index 2ebb985..091ceda 100644
> --- a/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> +++ b/textLayout/src/flashx/textLayout/utils/NavigationUtil.as
> @@ -1112,7 +1112,8 @@ package flashx.textLayout.utils
> if (range.absoluteEnd >= flowComposer.damageAbsoluteStart - 1)
> {
> clampToFit(range, flowComposer.damageAbsoluteStart - 1);
> - return true;
> + return false;
> + //return true;
> }
> if (flowComposer && flowComposer.numControllers)
> {
>