You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/05/07 01:43:24 UTC

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22862


Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................

IMPALA-14039: __restore_query_options should unset query option

ImpalaTestSuite.__restore_query_options() attempt to restore client's
configuration with what it understand as the "default" query option.

Since IMPALA-13930, ImpalaConnection.get_default_configuration() parse
the default query option from TQueryOption fields. Therefore, it might
not respect server's default that comes from --default_query_options
flag.

ImpalaTestSuite.__restore_query_options() should simply unset any
configuration that previously set by running SET query like this:

SET query_option="";

This patch also change execute_query_using_vector() to simply unset
client's configuration.

Testing:
Run and pass test_queries.py::TestQueries.

Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
---
M tests/common/impala_connection.py
M tests/common/impala_test_suite.py
2 files changed, 13 insertions(+), 28 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/22862/1
-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22862/5/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/22862/5/tests/common/impala_connection.py@238
PS5, Line 238:     return DEFAULT_QUERY_OPTIONS.copy()
> Do we want to keep this change from IMPALA-13930? Or remove get_default_con
I'd like to keep it for now, in case I need to backport it.
Will clean this up as separate patches. More codes need to be cleaned up following this removal.



-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 19:16:26 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19135/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 05:19:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 6:

(1 comment)

Thanks for putting this together, this makes sense to me

http://gerrit.cloudera.org:8080/#/c/22862/6/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/22862/6/tests/common/impala_connection.py@235
PS6, Line 235: --default_configuration_options
Is this default_query_options?



-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 18:24:48 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19132/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 02:19:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 9:

(1 comment)

> Patch Set 8:
> 
> (7 comments)
> 
> Thanks a lot for working on this Riza!
> 
> I only have some minor comments on the patch.

Hi Fang-Yu,
I'm sorry, the GVO has already run when you left your comments.

http://gerrit.cloudera.org:8080/#/c/22862/8/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/22862/8/tests/common/impala_connection.py@637
PS8, Line 637: , ""
> Is it true that a default value of empty string is required after this patc
It is not.
It just a default value to say we don't need to populate the query_options dictionary if value given is an empty string.



-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 May 2025 00:56:24 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22862/3/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/22862/3/tests/common/impala_connection.py@639
PS3, Line 639: del self.__query_options[name]
I think this wrong.
Once set, the key should stay, even if the value is an empty string.
Impala can interpret empty value as query option reset.



-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 02:27:04 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11849/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 04:14:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 8:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11861/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 18:33:32 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22862

to look at the new patch set (#3).

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................

IMPALA-14039: __restore_query_options should unset query option

ImpalaTestSuite.__restore_query_options() attempt to restore client's
configuration with what it understand as the "default" query option.

Since IMPALA-13930, ImpalaConnection.get_default_configuration() parse
the default query option from TQueryOption fields. Therefore, it might
not respect server's default that comes from --default_query_options
flag.

ImpalaTestSuite.__restore_query_options() should simply unset any
configuration that previously set by running SET query like this:

SET query_option="";

This patch also change execute_query_using_vector() to simply unset
client's configuration.

Testing:
Run and pass test_queries.py::TestQueries.

Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
---
M tests/common/impala_connection.py
M tests/common/impala_test_suite.py
2 files changed, 14 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/22862/3
-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 4:

Build Failed 

https://jenkins.impala.io/job/gerrit-code-review-checks/19134/ : Initial code review checks failed. See linked job for details on the failure.


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 04:41:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22862/3/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/22862/3/tests/common/impala_connection.py@639
PS3, Line 639: self.log_client("\n\nset {0}={
> I think this wrong.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 04:14:13 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Daniel Becker, Joe McDonnell, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22862

to look at the new patch set (#7).

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................

IMPALA-14039: __restore_query_options should unset query option

ImpalaTestSuite.__restore_query_options() attempt to restore client's
configuration with what it understand as the "default" query option.

Since IMPALA-13930, ImpalaConnection.get_default_configuration() parse
the default query option from TQueryOption fields. Therefore, it might
not respect server's default that comes from --default_query_options
flag.

ImpalaTestSuite.__restore_query_options() should simply unset any
configuration that previously set by running SET query like this:

SET query_option="";

This patch also change execute_query_using_vector() to simply unset
client's configuration.

Follow up cleanup will be tracked through IMPALA-14060.

Testing:
Run and pass test_queries.py::TestQueries.

Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
---
M tests/common/impala_connection.py
M tests/common/impala_test_suite.py
2 files changed, 10 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/22862/7
-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 9:

> Patch Set 9:
> 
> (1 comment)
> 
> > Patch Set 8:
> > 
> > (7 comments)
> > 
> > Thanks a lot for working on this Riza!
> > 
> > I only have some minor comments on the patch.
> 
> Hi Fang-Yu,
> I'm sorry, the GVO has already run when you left your comments.

No worries Riza.


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 May 2025 01:07:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 7: Code-Review+2

This looks good


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 18:30:25 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 7:

Thank you everyone!


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 18:31:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22862

to look at the new patch set (#2).

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................

IMPALA-14039: __restore_query_options should unset query option

ImpalaTestSuite.__restore_query_options() attempt to restore client's
configuration with what it understand as the "default" query option.

Since IMPALA-13930, ImpalaConnection.get_default_configuration() parse
the default query option from TQueryOption fields. Therefore, it might
not respect server's default that comes from --default_query_options
flag.

ImpalaTestSuite.__restore_query_options() should simply unset any
configuration that previously set by running SET query like this:

SET query_option="";

This patch also change execute_query_using_vector() to simply unset
client's configuration.

Testing:
Run and pass test_queries.py::TestQueries.

Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
---
M tests/common/impala_connection.py
M tests/common/impala_test_suite.py
2 files changed, 14 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/22862/2
-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 6:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19146/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 17:36:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22862/6/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/22862/6/tests/common/impala_connection.py@235
PS6, Line 235: --default_query_options flag va
> Is this default_query_options?
Oops, that's a mistake. Fixed.



-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 18:27:56 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 8: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 May 2025 00:48:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22862/5/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/22862/5/tests/common/impala_connection.py@238
PS5, Line 238:     return DEFAULT_QUERY_OPTIONS.copy()
Do we want to keep this change from IMPALA-13930? Or remove get_default_configuration? I think it's unused after this patch.



-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 19:08:37 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 8: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 18:38:14 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................

IMPALA-14039: __restore_query_options should unset query option

ImpalaTestSuite.__restore_query_options() attempt to restore client's
configuration with what it understand as the "default" query option.

Since IMPALA-13930, ImpalaConnection.get_default_configuration() parse
the default query option from TQueryOption fields. Therefore, it might
not respect server's default that comes from --default_query_options
flag.

ImpalaTestSuite.__restore_query_options() should simply unset any
configuration that previously set by running SET query like this:

SET query_option="";

This patch also change execute_query_using_vector() to simply unset
client's configuration.

Follow up cleanup will be tracked through IMPALA-14060.

Testing:
Run and pass test_queries.py::TestQueries.

Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Reviewed-on: http://gerrit.cloudera.org:8080/22862
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Jason Fehr <jf...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/impala_connection.py
M tests/common/impala_test_suite.py
2 files changed, 10 insertions(+), 28 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified
  Jason Fehr: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22862

to look at the new patch set (#5).

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................

IMPALA-14039: __restore_query_options should unset query option

ImpalaTestSuite.__restore_query_options() attempt to restore client's
configuration with what it understand as the "default" query option.

Since IMPALA-13930, ImpalaConnection.get_default_configuration() parse
the default query option from TQueryOption fields. Therefore, it might
not respect server's default that comes from --default_query_options
flag.

ImpalaTestSuite.__restore_query_options() should simply unset any
configuration that previously set by running SET query like this:

SET query_option="";

This patch also change execute_query_using_vector() to simply unset
client's configuration.

Testing:
Run and pass test_queries.py::TestQueries.

Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
---
M tests/common/impala_connection.py
M tests/common/impala_test_suite.py
2 files changed, 9 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/22862/5
-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22862/5/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/22862/5/tests/common/impala_connection.py@238
PS5, Line 238:     return DEFAULT_QUERY_OPTIONS.copy()
> I'd like to keep it for now, in case I need to backport it.
Can you add a TODO for it, ideally with a Jira number for that?



-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 08:48:23 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22862/5/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/22862/5/tests/common/impala_connection.py@238
PS5, Line 238:     IMPALA-14060: Remove this and related functions."""
> Can you add a TODO for it, ideally with a Jira number for that?
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 17:10:17 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 8: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 18:33:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 5: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 19:19:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Daniel Becker, Joe McDonnell, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22862

to look at the new patch set (#6).

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................

IMPALA-14039: __restore_query_options should unset query option

ImpalaTestSuite.__restore_query_options() attempt to restore client's
configuration with what it understand as the "default" query option.

Since IMPALA-13930, ImpalaConnection.get_default_configuration() parse
the default query option from TQueryOption fields. Therefore, it might
not respect server's default that comes from --default_query_options
flag.

ImpalaTestSuite.__restore_query_options() should simply unset any
configuration that previously set by running SET query like this:

SET query_option="";

This patch also change execute_query_using_vector() to simply unset
client's configuration.

Follow up cleanup will be tracked through IMPALA-14060.

Testing:
Run and pass test_queries.py::TestQueries.

Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
---
M tests/common/impala_connection.py
M tests/common/impala_test_suite.py
2 files changed, 10 insertions(+), 28 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/22862/6
-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 7:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19147/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 18:55:45 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 8:

(7 comments)

Thanks a lot for working on this Riza!

I only have some minor comments on the patch.

http://gerrit.cloudera.org:8080/#/c/22862/8//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22862/8//COMMIT_MSG@9
PS8, Line 9: attempt
nit: attempts


http://gerrit.cloudera.org:8080/#/c/22862/8//COMMIT_MSG@10
PS8, Line 10: understand
nit: understands


http://gerrit.cloudera.org:8080/#/c/22862/8//COMMIT_MSG@12
PS8, Line 12: parse
nit: parses


http://gerrit.cloudera.org:8080/#/c/22862/8//COMMIT_MSG@18
PS8, Line 18: that
nit: that were


http://gerrit.cloudera.org:8080/#/c/22862/8//COMMIT_MSG@22
PS8, Line 22: change
nit: changes


http://gerrit.cloudera.org:8080/#/c/22862/8/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/22862/8/tests/common/impala_connection.py@233
PS8, Line 233: Return
nit: Returns


http://gerrit.cloudera.org:8080/#/c/22862/8/tests/common/impala_connection.py@637
PS8, Line 637: , ""
Is it true that a default value of empty string is required after this patch? If so, could we elaborate on this a little bit?



-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 May 2025 23:05:08 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22862/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22862/5//COMMIT_MSG@26
PS5, Line 26: Run and pass test_queries.py::TestQueries.
I ran a core tests overnight and it pass.



-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 17:13:03 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19130/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 02:10:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22862 )

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19131/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 May 2025 02:13:12 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-14039: restore query options should unset query option

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Fang-Yu Rao, Joe McDonnell, Michael Smith, Impala Public Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/22862

to look at the new patch set (#4).

Change subject: IMPALA-14039: __restore_query_options should unset query option
......................................................................

IMPALA-14039: __restore_query_options should unset query option

ImpalaTestSuite.__restore_query_options() attempt to restore client's
configuration with what it understand as the "default" query option.

Since IMPALA-13930, ImpalaConnection.get_default_configuration() parse
the default query option from TQueryOption fields. Therefore, it might
not respect server's default that comes from --default_query_options
flag.

ImpalaTestSuite.__restore_query_options() should simply unset any
configuration that previously set by running SET query like this:

SET query_option="";

This patch also change execute_query_using_vector() to simply unset
client's configuration.

Testing:
Run and pass test_queries.py::TestQueries.

Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
---
M tests/common/impala_connection.py
M tests/common/impala_test_suite.py
2 files changed, 10 insertions(+), 29 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/22862/4
-- 
To view, visit http://gerrit.cloudera.org:8080/22862
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I884986b9ecbcabf0b34a7346220e6ea4142ca923
Gerrit-Change-Number: 22862
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>